drive: Stop mentioning about symlinks

drive: Stop mentioning about symlinks

BUG=244343
R=satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202803

[satorux1, 2013-05-28 07:56:33]

LGTM

[commit-bot: I haz the power, 2013-05-28 07:57:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/15878006/2001

[commit-bot: I haz the power, 2013-05-28 13:43:29]

Failed to apply patch for chrome/browser/chromeos/drive/file_cache.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chromeos/drive/file_cache.h
  Hunk #4 FAILED at 236.
  1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/drive/file_cache.h.rej

Patch:       chrome/browser/chromeos/drive/file_cache.h
Index: chrome/browser/chromeos/drive/file_cache.h
diff --git a/chrome/browser/chromeos/drive/file_cache.h
b/chrome/browser/chromeos/drive/file_cache.h
index
bef7635c9ef455c2c266caaa94b7947b93fa4bcd..56f6e9143e3bd2e7f4388b9f7c57f58f9c2ff20e
100644
--- a/chrome/browser/chromeos/drive/file_cache.h
+++ b/chrome/browser/chromeos/drive/file_cache.h
@@ -122,9 +122,7 @@ class FileCache {
   // Gets the cache entry for file corresponding to |resource_id| and |md5|
   // and runs |callback| with true and the entry found if entry exists in cache
   // map.  Otherwise, runs |callback| with false.
-  // |md5| can be empty if only matching |resource_id| is desired, which may
-  // happen when looking for pinned entries where symlinks' filenames have no
-  // extension and hence no md5.
+  // |md5| can be empty if only matching |resource_id| is desired.
   // |callback| must not be null.
   // Must be called on the UI thread.
   void GetCacheEntryOnUIThread(const std::string& resource_id,
@@ -206,11 +204,7 @@ class FileCache {
                                       FileOperationType file_operation_type,
                                       const FileOperationCallback& callback);
 
-  // Modifies cache state, which involves the following:
-  // - moves |source_path| to |dest_path| in persistent dir if
-  //   file is not dirty
-  // - creates symlink in pinned dir that references downloaded or locally
-  //   modified file
+  // Pins the specified entry.
   // |callback| must not be null.
   // Must be called on the UI thread.
   void PinOnUIThread(const std::string& resource_id,
@@ -225,9 +219,7 @@ class FileCache {
                        const std::string& md5,
                        const FileOperationCallback& callback);
 
-  // Modifies cache state, which involves the following:
-  // - moves the local file from pinned directory to unpinned directory.
-  // - update cache metadata.
+  // Unpins the specified entry.
   FileError Unpin(const std::string& resource_id, const std::string& md5);
 
   // Sets the state of the cache entry corresponding to |resource_id| and |md5|
@@ -244,31 +236,21 @@ class FileCache {
   void MarkAsUnmountedOnUIThread(const base::FilePath& file_path,
                                  const FileOperationCallback& callback);
 
-  // Modifies cache state, which involves the following:
-  // - moves |source_path| to |dest_path| in persistent dir, where
-  //   |source_path| has .<md5> extension and |dest_path| has .local extension
-  // - if file is pinned, updates symlink in pinned dir to reference dirty file
+  // Marks the specified entry dirty.
   // |callback| must not be null.
   // Must be called on the UI thread.
   void MarkDirtyOnUIThread(const std::string& resource_id,
                            const std::string& md5,
                            const FileOperationCallback& callback);
 
-  // Modifies cache state, i.e. creates symlink in outgoing
-  // dir to reference dirty file in persistent dir.
+  // Commits changes for the specified dirty entry.
   // |callback| must not be null.
   // Must be called on the UI thread.
   void CommitDirtyOnUIThread(const std::string& resource_id,
                              const std::string& md5,
                              const FileOperationCallback& callback);
 
-  // Modifies cache state, which involves the following:
-  // - moves |source_path| to |dest_path| in persistent dir if
-  //   file is pinned or tmp dir otherwise, where |source_path| has .local
-  //   extension and |dest_path| has .<md5> extension
-  // - deletes symlink in outgoing dir
-  // - if file is pinned, updates symlink in pinned dir to reference
-  //   |dest_path|
+  // Clears dirty state of the specified entry.
   // |callback| must not be null.
   // Must be called on the UI thread.
   void ClearDirtyOnUIThread(const std::string& resource_id,

[commit-bot: I haz the power, 2013-05-29 03:47:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/15878006/17001

[commit-bot: I haz the power, 2013-05-29 04:18:14]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[hashimoto, 2013-05-29 07:47:42]

Committed patchset #2 manually as r202803 (presubmit successful).