Add in option to always disable gsutil version check

Add in option to always disable gsutil version check

In theory this shouldn't fire if gsutil is running without a tty (ie, in a subprocess).
In practice we're still seeing processes hang because it still thinks it's in a tty
This should in theory disable the prompt for good

BUG=577325, 576979
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299714

[hinoka, 2016-01-13 21:32:06]

hinoka@chromium.org changed reviewers:
+ friedman@chromium.org, mfschwartz@google.com

[hinoka, 2016-01-13 21:32:07]

+friedman review
+mfschwartz to make sure I got the flag right

[hinoka, 2016-01-13 21:32:16]

Description was changed from

==========
Add in option to alwasy disable gsutil version check

In theory this shouldn't fire if gsutil is running without a tty (ie, in a
subprocess).
In practice we're still seeing processes hang because it still thinks it's in a
tty
This should in theory disable the prompt for good

BUG=577325,576979
==========

to

==========
Add in option to always disable gsutil version check

In theory this shouldn't fire if gsutil is running without a tty (ie, in a
subprocess).
In practice we're still seeing processes hang because it still thinks it's in a
tty
This should in theory disable the prompt for good

BUG=577325,576979
==========

[friedman1, 2016-01-13 21:34:01]

friedman@google.com changed reviewers:
+ friedman@google.com

[friedman1, 2016-01-13 21:34:02]

lgtm

[mfschwartz, 2016-01-13 21:36:19]

This change isn't necessary. You can disable all gsutil periodic software update
checks by setting:

software_update_check_period = 0

in the [GSUtil] section of your .boto file.

[hinoka, 2016-01-13 21:39:23]

We don't always have a boto file (some machines run on GCE).  It's also
easier for us to push code changes than credential file changes.

On Wed, Jan 13, 2016 at 1:36 PM, <mfschwartz@google.com> wrote:

> This change isn't necessary. You can disable all gsutil periodic software
> update
> checks by setting:
>
> software_update_check_period = 0
>
> in the [GSUtil] section of your .boto file.
>
> https://codereview.chromium.org/1587793002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-01-13 21:49:06]

I see. Ok, the way you have it should work, then.

I'd still like to understand (per other email thread) why the chrome
buildbot is looking like an interactive process to gsutil, since this same
problem might be affecting other customers too.

On Wed, Jan 13, 2016 at 2:39 PM, Ryan Tseng <hinoka@chromium.org> wrote:

> We don't always have a boto file (some machines run on GCE).  It's also
> easier for us to push code changes than credential file changes.
>
> On Wed, Jan 13, 2016 at 1:36 PM, <mfschwartz@google.com> wrote:
>
>> This change isn't necessary. You can disable all gsutil periodic software
>> update
>> checks by setting:
>>
>> software_update_check_period = 0
>>
>> in the [GSUtil] section of your .boto file.
>>
>> https://codereview.chromium.org/1587793002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hinoka, 2016-01-13 21:53:10]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-01-13 21:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587793002/1

[commit-bot: I haz the power, 2016-01-13 23:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 23:53:32]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[hinoka, 2016-04-05 23:54:34]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-04-05 23:54:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587793002/1

[commit-bot: I haz the power, 2016-04-05 23:57:12]

Description was changed from

==========
Add in option to always disable gsutil version check

In theory this shouldn't fire if gsutil is running without a tty (ie, in a
subprocess).
In practice we're still seeing processes hang because it still thinks it's in a
tty
This should in theory disable the prompt for good

BUG=577325,576979
==========

to

==========
Add in option to always disable gsutil version check

In theory this shouldn't fire if gsutil is running without a tty (ie, in a
subprocess).
In practice we're still seeing processes hang because it still thinks it's in a
tty
This should in theory disable the prompt for good

BUG=577325,576979

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299714
==========

[commit-bot: I haz the power, 2016-04-05 23:57:13]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299714