Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1587763002: Revert of [wasm] Add tests for JS wrappers to test-run-wasm. (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
titzer, bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Add tests for JS wrappers to test-run-wasm. (patchset #1 id:1 of https://codereview.chromium.org/1581643004/ ) Reason for revert: New test failed on nosnap builder (https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/4738): Test: cctest/test-run-wasm-js/Run_CallJS_Add_jswrapped Stderr: abort: Sloppy function expects JSReceiver as receiver. # # Fatal error in ../../src/objects-inl.h, line 3221 # Check failed: !v8::internal::FLAG_enable_slow_asserts || (object->IsJSFunction()). # Original issue's description: > [wasm] Add tests for JS wrappers to test-run-wasm. > > R=bradnelson@chromium.org, ahaas@chromium.org > BUG= > > Committed: https://crrev.com/c52f5ced4e600a57c02301f2936b80f086613985 > Cr-Commit-Position: refs/heads/master@{#33274} TBR=ahaas@chromium.org,bradnelson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a3a6bd4128c60bd1f569e4d947d70bbf49cb2eb6 Cr-Commit-Position: refs/heads/master@{#33275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -552 lines) Patch
M src/wasm/wasm-js.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/wasm/wasm-js.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 2 chunks +375 lines, -2 lines 0 comments Download
D test/cctest/wasm/test-run-wasm-js.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D test/cctest/wasm/wasm-run-utils.h View 1 chunk +0 lines, -391 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
Created Revert of [wasm] Add tests for JS wrappers to test-run-wasm.
4 years, 11 months ago (2016-01-13 21:00:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587763002/1
4 years, 11 months ago (2016-01-13 21:00:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 21:01:08 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 21:02:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3a6bd4128c60bd1f569e4d947d70bbf49cb2eb6
Cr-Commit-Position: refs/heads/master@{#33275}

Powered by Google App Engine
This is Rietveld 408576698