Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1587753002: Use update.py --print-clang-version in build/mac/asan.gyp (Closed)

Created:
4 years, 11 months ago by hans
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use update.py --print-clang-version in build/mac/asan.gyp This matches what we do in build/win/asan.gyp and avoids the problem that the wildcard can match multiple directories, which can happen when the version changes. BUG=none R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e5c134116a97f8c6dfc580de2a3ae9d3d74a9dfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/mac/asan.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hans
Please take a look.
4 years, 11 months ago (2016-01-13 20:34:12 UTC) #2
Nico
lgtm; i suppose gn just doesn't have this piece yet.
4 years, 11 months ago (2016-01-13 20:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587753002/1
4 years, 11 months ago (2016-01-13 20:51:48 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5c134116a97f8c6dfc580de2a3ae9d3d74a9dfd Cr-Commit-Position: refs/heads/master@{#369268}
4 years, 11 months ago (2016-01-13 21:02:41 UTC) #7
hans
4 years, 11 months ago (2016-01-13 21:03:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5c134116a97f8c6dfc580de2a3ae9d3d74a9dfd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698