Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: content/renderer/gpu/render_widget_compositor.h

Issue 1587743002: RenderWidgetCompositor should be decoupled from RenderWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.h
diff --git a/content/renderer/gpu/render_widget_compositor.h b/content/renderer/gpu/render_widget_compositor.h
index 0eac7cd9739241ff7fd56d0fc482ab1c59a8ad0b..9600506a5e0fbf8967d503e0b72b40e5fd4927a2 100644
--- a/content/renderer/gpu/render_widget_compositor.h
+++ b/content/renderer/gpu/render_widget_compositor.h
@@ -42,7 +42,8 @@ class CompositorMessage;
}
namespace content {
-class RenderWidget;
+
+class RenderWidgetCompositorDelegate;
class CONTENT_EXPORT RenderWidgetCompositor
: NON_EXPORTED_BASE(public blink::WebLayerTreeView),
@@ -53,7 +54,8 @@ class CONTENT_EXPORT RenderWidgetCompositor
// Attempt to construct and initialize a compositor instance for the widget
// with the given settings. Returns NULL if initialization fails.
static scoped_ptr<RenderWidgetCompositor> Create(
- RenderWidget* widget,
+ RenderWidgetCompositorDelegate* delegate,
+ float device_scale_factor,
CompositorDependencies* compositor_deps);
~RenderWidgetCompositor() override;
@@ -184,10 +186,10 @@ class CONTENT_EXPORT RenderWidgetCompositor
};
protected:
- RenderWidgetCompositor(RenderWidget* widget,
+ RenderWidgetCompositor(RenderWidgetCompositorDelegate* delegate,
CompositorDependencies* compositor_deps);
- void Initialize();
+ void Initialize(float device_scale_factor);
cc::LayerTreeHost* layer_tree_host() { return layer_tree_host_.get(); }
private:
@@ -197,8 +199,8 @@ class CONTENT_EXPORT RenderWidgetCompositor
void SynchronouslyComposite();
int num_failed_recreate_attempts_;
- RenderWidget* widget_;
- CompositorDependencies* compositor_deps_;
+ RenderWidgetCompositorDelegate* const delegate_;
+ CompositorDependencies* const compositor_deps_;
scoped_ptr<cc::LayerTreeHost> layer_tree_host_;
bool never_visible_;

Powered by Google App Engine
This is Rietveld 408576698