Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1587743002:
RenderWidgetCompositor should be decoupled from RenderWidget. (Closed)
|
Created:
4 years, 11 months ago by Fady Samuel Modified:
4 years, 11 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRenderWidgetCompositor should be decoupled from RenderWidget.
This is a mechanical refactor of RenderWidgetCompositor and
RenderWidget. At this point it removes references for
routing ID, and RenderWidget from RenderWidgetCompositor's
implementation. This is likely not the final refactor as I
am still in the process of detangling WebWidgetClient's
implementation from RenderWidget. Once that happens, I
might have some simplifications.
BUG=577321
Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751
Cr-Commit-Position: refs/heads/master@{#369383}
Committed: https://crrev.com/78f86e4a1f05241ed5dae1d67faeeec8e87a4351
Cr-Commit-Position: refs/heads/master@{#370298}
Patch Set 1 #Patch Set 2 : Remove unnecessary changes #Patch Set 3 : Remove unnecessary include #Patch Set 4 : Cleanup #
Total comments: 8
Patch Set 5 : Addressed some of piman's concenrs #Patch Set 6 : device_scale_factor => initial_device_scale_factor #Patch Set 7 : Fixed render_widget_compositor_unittest.cc #Patch Set 8 : Fixed failure: Don't create an OutputSurface when closing #
Messages
Total messages: 35 (18 generated)
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. BUG= ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. BUG=577321 ==========
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. BUG=577321 ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor/RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 ==========
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor/RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 ==========
fsamuel@chromium.org changed reviewers: + piman@chromium.org
piman@chromium.org changed reviewers: + chrishtr@chromium.org, danakj@chromium.org
Thanks, the interface cleanup goes along the lines of what I was thinking! One main thing, and nits. +Chris/Dana, do you have an opinion about order of updateAllLifecyclePhases vs AnimateLayers? https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.cc (left): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.cc:885: widget_->webwidget()->updateAllLifecyclePhases(); So if I understand correctly, this moved from here to the end of BeginMainFrame. Relative to the code in LayerTreeHost, it means it moves before AnimateLayers. Not knowing the details of updateAllLifecyclePhases, I don't know if it's ok or not. +danakj/chrishtr, do you know? https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.cc:209: float device_scale_factor, Minor nit, this makes it sound like the device_scale_factor is fixed in time, whereas in truth it can change if a tab is moved to a different screen. I guess we're only using the initial DSF for the tile size computation, maybe that one should move to RenderWidget, and explicitly pass the default tile size here? (dunno if mus would use different heuristics there) https://codereview.chromium.org/1587743002/diff/60001/content/renderer/render... File content/renderer/render_widget.h (right): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/render... content/renderer/render_widget.h:343: bool host_closing() const { return host_closing_; } nit: I think this can now be made private.
https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.cc (left): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.cc:885: widget_->webwidget()->updateAllLifecyclePhases(); On 2016/01/13 22:09:30, piman (Slow to review) wrote: > So if I understand correctly, this moved from here to the end of BeginMainFrame. > Relative to the code in LayerTreeHost, it means it moves before AnimateLayers. > Not knowing the details of updateAllLifecyclePhases, I don't know if it's ok or > not. +danakj/chrishtr, do you know? Take a look here, the time when things run matters: https://code.google.com/p/chromium/codesearch#chromium/src/cc/trees/proxy_mai... During the "animate step" requests for new frames will in fact cause another new frame. During the "update step" which is the UpdateLayerTreeHost() method here, properties can be changed on layers without causing another frame to happen. BeginMainFrame() happens before the animate and has properties more like the animate step. Also UpdateLayers does not always happen unless it's requested, so moving this work out of this function changes it to run always instead of obeying the logic in proxy_main there.
PTAL, piman@. I've restored the code to avoid semantic changes. I didn't do the device_scale_factor suggestion though. It seems like tile size is a compositor implementation detail and exposing it outside of RenderWidgetCompositor seems odd to me. WDYT? https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.cc (left): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.cc:885: widget_->webwidget()->updateAllLifecyclePhases(); On 2016/01/13 22:24:33, danakj wrote: > On 2016/01/13 22:09:30, piman (Slow to review) wrote: > > So if I understand correctly, this moved from here to the end of > BeginMainFrame. > > Relative to the code in LayerTreeHost, it means it moves before AnimateLayers. > > Not knowing the details of updateAllLifecyclePhases, I don't know if it's ok > or > > not. +danakj/chrishtr, do you know? > > Take a look here, the time when things run matters: > https://code.google.com/p/chromium/codesearch#chromium/src/cc/trees/proxy_mai... > > During the "animate step" requests for new frames will in fact cause another new > frame. > > During the "update step" which is the UpdateLayerTreeHost() method here, > properties can be changed on layers without causing another frame to happen. > > BeginMainFrame() happens before the animate and has properties more like the > animate step. > > Also UpdateLayers does not always happen unless it's requested, so moving this > work out of this function changes it to run always instead of obeying the logic > in proxy_main there. I don't want to change semantics in this CL so I've added a UpdateVisualState call out. https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.cc:209: float device_scale_factor, On 2016/01/13 22:09:30, piman (Slow to review) wrote: > Minor nit, this makes it sound like the device_scale_factor is fixed in time, > whereas in truth it can change if a tab is moved to a different screen. I guess > we're only using the initial DSF for the tile size computation, maybe that one > should move to RenderWidget, and explicitly pass the default tile size here? > (dunno if mus would use different heuristics there) Hmm, tile size seems like a compositor detail. I'd prefer not to put it in RenderWidget. Perhaps I can add a GetDeviceScaleFactor() to the delegate? https://codereview.chromium.org/1587743002/diff/60001/content/renderer/render... File content/renderer/render_widget.h (right): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/render... content/renderer/render_widget.h:343: bool host_closing() const { return host_closing_; } On 2016/01/13 22:09:30, piman (Slow to review) wrote: > nit: I think this can now be made private. Done.
lgtm https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.cc (right): https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.cc:209: float device_scale_factor, On 2016/01/13 23:48:13, Fady Samuel wrote: > On 2016/01/13 22:09:30, piman (Slow to review) wrote: > > Minor nit, this makes it sound like the device_scale_factor is fixed in time, > > whereas in truth it can change if a tab is moved to a different screen. I > guess > > we're only using the initial DSF for the tile size computation, maybe that one > > should move to RenderWidget, and explicitly pass the default tile size here? > > (dunno if mus would use different heuristics there) > > Hmm, tile size seems like a compositor detail. I'd prefer not to put it in > RenderWidget. Perhaps I can add a GetDeviceScaleFactor() to the delegate? There's already RWC::setDeviceScaleFactor, I wouldn't want 3 ways of passing the same info. Maybe simply naming it initial_device_scale_factor to make it clear that it's not set in stone?
On 2016/01/14 00:13:23, piman (Slow to review) wrote: > lgtm > > https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... > File content/renderer/gpu/render_widget_compositor.cc (right): > > https://codereview.chromium.org/1587743002/diff/60001/content/renderer/gpu/re... > content/renderer/gpu/render_widget_compositor.cc:209: float device_scale_factor, > On 2016/01/13 23:48:13, Fady Samuel wrote: > > On 2016/01/13 22:09:30, piman (Slow to review) wrote: > > > Minor nit, this makes it sound like the device_scale_factor is fixed in > time, > > > whereas in truth it can change if a tab is moved to a different screen. I > > guess > > > we're only using the initial DSF for the tile size computation, maybe that > one > > > should move to RenderWidget, and explicitly pass the default tile size here? > > > (dunno if mus would use different heuristics there) > > > > Hmm, tile size seems like a compositor detail. I'd prefer not to put it in > > RenderWidget. Perhaps I can add a GetDeviceScaleFactor() to the delegate? > > There's already RWC::setDeviceScaleFactor, I wouldn't want 3 ways of passing the > same info. > Maybe simply naming it initial_device_scale_factor to make it clear that it's > not set in stone? Done. CQ'ing. Thanks!
The CQ bit was checked by fsamuel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/1587743002/#ps100001 (title: "device_scale_factor => initial_device_scale_factor")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587743002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587743002/100001
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fsamuel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/1587743002/#ps120001 (title: "Fixed render_widget_compositor_unittest.cc")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587743002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587743002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587743002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587743002/120001
Message was sent while issue was closed.
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1586523004/ by vasilii@chromium.org. The reason for reverting is: Broke browser_tests on Mac10.6 Tests https://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests... [ RUN ] PlatformAppBrowserTest.AppWindowRestoreState [40491:263:0114/023453:ERROR:display_scheduler.cc(158)] Not implemented reached in virtual void cc::DisplayScheduler::OnBeginFrameSourcePausedChanged(bool) [40491:26115:0114/023453:WARNING:message_in_transit_queue.cc(17)] Destroying nonempty message queue [40498:263:0114/023453:FATAL:render_widget_compositor.cc(933)] Failed to create a fallback OutputSurface. 0 Chromium Framework 0x0000000101587c13 _ZN4base5debug10StackTraceC1Ev + 19 1 Chromium Framework 0x000000010159ff19 _ZN7logging10LogMessageD2Ev + 73 2 Chromium Framework 0x00000001053393ee _ZN7content22RenderWidgetCompositor32DidFailToInitializeOutputSurfaceEv + 110 3 Chromium Framework 0x00000001053392ab _ZN7content22RenderWidgetCompositor23RequestNewOutputSurfaceEv + 107 4 Chromium Framework 0x000000010158812a _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 202 5 Chromium Framework 0x00000001052d6600 _ZN9scheduler16TaskQueueManager24ProcessTaskFromWorkQueueEPNS_8internal9WorkQueueEPNS1_13TaskQueueImpl4TaskE + 688 6 Chromium Framework 0x00000001052d542e _ZN9scheduler16TaskQueueManager6DoWorkEN4base9TimeTicksEb + 286 7 Chromium Framework 0x000000010158812a _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 202 8 Chromium Framework 0x00000001015aac29 _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 489 9 Chromium Framework 0x00000001015ab168 _ZN4base11MessageLoop6DoWorkEv + 632 10 Chromium Framework 0x000000010157d041 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 49 11 Chromium Framework 0x00000001015a102a _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10 12 Chromium Framework 0x000000010157ca44 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 68 13 CoreFoundation 0x00007fff83c433d1 __CFRunLoopDoSources0 + 1361 14 CoreFoundation 0x00007fff83c415c9 __CFRunLoopRun + 873 15 CoreFoundation 0x00007fff83c40d8f CFRunLoopRunSpecific + 575 16 Foundation 0x00007fff86fbdb74 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 270 17 Chromium Framework 0x000000010157d6fe _ZN4base20MessagePumpNSRunLoop5DoRunEPNS_11MessagePump8DelegateE + 126 18 Chromium Framework 0x000000010157ce94 _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 100 19 Chromium Framework 0x00000001015bd553 _ZN4base7RunLoop3RunEv + 99 20 Chromium Framework 0x00000001015aa3cd _ZN4base11MessageLoop3RunEv + 29 21 Chromium Framework 0x00000001053bc287 _ZN7content12RendererMainERKNS_18MainFunctionParamsE + 1175 22 Chromium Framework 0x000000010153d26c _ZN7content21ContentMainRunnerImpl3RunEv + 92 23 Chromium Framework 0x000000010153c736 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54 24 Chromium Framework 0x0000000101003192 ChromeMain + 66 25 Chromium Helper 0x000000019ede9d62 main + 530 26 Chromium Helper 0x000000019ede9b44 start + 52 27 ??? 0x0000000000000017 0x0 + 23 BrowserTestBase signal handler received SIGTERM. Backtrace: 0 browser_tests 0x0000000118bff553 _ZN4base5debug10StackTraceC1Ev + 19 1 browser_tests 0x000000011d087271 _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 65 2 libSystem.B.dylib 0x00007fff8a4291ba _sigtramp + 26 3 ??? 0x00007fff5fbfc208 0x0 + 140734799790600 4 CoreFoundation 0x00007fff83c41902 __CFRunLoopRun + 1698 5 CoreFoundation 0x00007fff83c40d8f CFRunLoopRunSpecific + 575 6 HIToolbox 0x00007fff815e57ee RunCurrentEventLoopInMode + 333 7 HIToolbox 0x00007fff815e55f3 ReceiveNextEventCommon + 310 8 HIToolbox 0x00007fff815e54ac BlockUntilNextEventMatchingListInMode + 59 9 AppKit 0x00007fff899d5eb2 _DPSNextEvent + 708 10 AppKit 0x00007fff899d5801 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 155 11 AppKit 0x00007fff8999b68f -[NSApplication run] + 395 12 browser_tests 0x0000000118bf528f _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 351 13 browser_tests 0x0000000118bf4844 _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 100 14 browser_tests 0x0000000118c33b03 _ZN4base7RunLoop3RunEv + 99 15 browser_tests 0x000000011d0d474f _ZN7content14RunThisRunLoopEPN4base7RunLoopE + 79 16 browser_tests 0x000000011d1d86aa _ZN10extensions13ResultCatcher13GetNextResultEv + 90 17 browser_tests 0x000000011858ccaa _ZN16ExtensionApiTest20RunExtensionTestImplERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEES8_PKci + 682 18 browser_tests 0x000000011858cf8e _ZN16ExtensionApiTest18RunPlatformAppTestERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE + 46 19 browser_tests 0x0000000117b5f430 _ZN10extensions49PlatformAppBrowserTest_AppWindowRestoreState_Test19RunTestOnMainThreadEv + 64 20 browser_tests 0x0000000118bed328 _ZN20InProcessBrowserTest23RunTestOnMainThreadLoopEv + 232 21 browser_tests 0x000000011d087034 _ZN7content15BrowserTestBase28ProxyRunTestOnMainThreadLoopEv + 244 22 browser_tests 0x0000000118759233 _ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv + 4067 23 browser_tests 0x000000011875812a _ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv + 122 24 browser_tests 0x000000011bd1202a _ZN7content15BrowserMainLoop21PreMainMessageLoopRunEv + 138 25 browser_tests 0x000000011bfbfc77 _ZN7content17StartupTaskRunner14RunAllTasksNowEv + 39 26 browser_tests 0x000000011bd106bf _ZN7content15BrowserMainLoop18CreateStartupTasksEv + 671 27 browser_tests 0x000000011bd146d0 _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 544 28 browser_tests 0x000000011bd0dfc5 _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 149 29 browser_tests 0x000000011d085ccc _ZN7content21ContentMainRunnerImpl3RunEv + 92 30 browser_tests 0x000000011d085196 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54 31 browser_tests 0x000000011d086d95 _ZN7content15BrowserTestBase5SetUpEv + 869 32 browser_tests 0x0000000118bec74e _ZN20InProcessBrowserTest5SetUpEv + 222 33 browser_tests 0x000000011908206b _ZN7testing4Test3RunEv + 299 34 browser_tests 0x0000000119082cba _ZN7testing8TestInfo3RunEv + 410 35 browser_tests 0x0000000119083283 _ZN7testing8TestCase3RunEv + 451 36 browser_tests 0x0000000119089949 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 825 37 browser_tests 0x00000001190895dd _ZN7testing8UnitTest3RunEv + 269 38 browser_tests 0x0000000118c94149 _ZN4base9TestSuite3RunEv + 217 39 browser_tests 0x000000011859342f _ZN28ChromeBrowserTestSuiteRunner12RunTestSuiteEiPPc + 31 40 browser_tests 0x000000011d0d1d51 _ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 321 41 browser_tests 0x0000000118bd2846 _Z17LaunchChromeTestsiP21ChromeTestSuiteRunneriPPc + 70 42 browser_tests 0x0000000118593401 main + 65 43 browser_tests 0x0000000117a9d734 start + 52 44 ??? 0x0000000000000008 0x0 + 8 [27/437] PlatformAppBrowserTest.AppWindowRestoreState (TIMED OUT).
Message was sent while issue was closed.
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} ==========
The CQ bit was checked by fsamuel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/1587743002/#ps140001 (title: "Fixed failure: Don't create an OutputSurface when closing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587743002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587743002/140001
Message was sent while issue was closed.
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} ========== to ========== RenderWidgetCompositor should be decoupled from RenderWidget. This is a mechanical refactor of RenderWidgetCompositor and RenderWidget. At this point it removes references for routing ID, and RenderWidget from RenderWidgetCompositor's implementation. This is likely not the final refactor as I am still in the process of detangling WebWidgetClient's implementation from RenderWidget. Once that happens, I might have some simplifications. BUG=577321 Committed: https://crrev.com/40b2fccfc256dccfdda03cc99e5b1d5b75d24751 Cr-Commit-Position: refs/heads/master@{#369383} Committed: https://crrev.com/78f86e4a1f05241ed5dae1d67faeeec8e87a4351 Cr-Commit-Position: refs/heads/master@{#370298} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/78f86e4a1f05241ed5dae1d67faeeec8e87a4351 Cr-Commit-Position: refs/heads/master@{#370298} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
