Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1587733003: GN(android): Fix unit_tests_apk compile of @integer/google_play_services_version (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android): Fix unit_tests_apk compile of @integer/google_play_services_version BUG=none TBR=pkotwicz NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/5a88649588e32c4e76a2e270308889d43a191b33 Cr-Commit-Position: refs/heads/master@{#369306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
pkotwicz
lgtm
4 years, 11 months ago (2016-01-14 03:01:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587733003/1
4 years, 11 months ago (2016-01-14 03:09:35 UTC) #6
agrieve
On 2016/01/14 03:09:35, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 11 months ago (2016-01-14 03:19:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587733003/1
4 years, 11 months ago (2016-01-14 03:24:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:29:57 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:31:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a88649588e32c4e76a2e270308889d43a191b33
Cr-Commit-Position: refs/heads/master@{#369306}

Powered by Google App Engine
This is Rietveld 408576698