Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1587723004: Merge to XFA: Fix another invalidated iterator issue while traversing CPDF_Dictionary. (Closed)

Created:
4 years, 11 months ago by Oliver Chang
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix another invalidated iterator issue while traversing CPDF_Dictionary. TBR=thestig@chromium.org (cherry picked from commit a626e39700abe56e98bc44a97c38eb8da077065e) Committed: https://pdfium.googlesource.com/pdfium/+/2c9cba136544dd305f5e83a120d4222d9a2b6c62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M core/src/fpdfdoc/doc_formcontrol.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Oliver Chang
TBR. clean merge.
4 years, 11 months ago (2016-01-14 05:57:42 UTC) #1
Oliver Chang
Committed patchset #1 (id:1) manually as 2c9cba136544dd305f5e83a120d4222d9a2b6c62 (presubmit successful).
4 years, 11 months ago (2016-01-14 05:57:50 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-14 06:24:31 UTC) #4
Message was sent while issue was closed.
lgtm

The link to the original code review is missing.

Powered by Google App Engine
This is Rietveld 408576698