Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: Source/bindings/v8/custom/V8MessageChannelCustom.cpp

Issue 15877002: move constructors to new style callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8MessageChannelCustom.cpp
diff --git a/Source/bindings/v8/custom/V8MessageChannelCustom.cpp b/Source/bindings/v8/custom/V8MessageChannelCustom.cpp
index 918f43ac5336ca59d110a5898e8596ba931553d5..e5d0b654bb6d7bb81ef9b0753743cbf97c5968f2 100644
--- a/Source/bindings/v8/custom/V8MessageChannelCustom.cpp
+++ b/Source/bindings/v8/custom/V8MessageChannelCustom.cpp
@@ -44,7 +44,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8MessageChannel::constructorCustom(const v8::Arguments& args)
+void V8MessageChannel::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
{
ScriptExecutionContext* context = getScriptExecutionContext();
@@ -59,7 +59,7 @@ v8::Handle<v8::Value> V8MessageChannel::constructorCustom(const v8::Arguments& a
V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);
- return wrapper;
+ args.GetReturnValue().Set(wrapper);
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8FormDataCustom.cpp ('k') | Source/bindings/v8/custom/V8MutationObserverCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698