Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: Source/bindings/v8/custom/V8AudioContextCustom.cpp

Issue 15877002: move constructors to new style callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 #include "bindings/v8/V8Binding.h" 34 #include "bindings/v8/V8Binding.h"
35 #include "core/dom/Document.h" 35 #include "core/dom/Document.h"
36 #include "core/page/Frame.h" 36 #include "core/page/Frame.h"
37 #include "modules/webaudio/AudioBuffer.h" 37 #include "modules/webaudio/AudioBuffer.h"
38 #include "modules/webaudio/AudioContext.h" 38 #include "modules/webaudio/AudioContext.h"
39 #include "modules/webaudio/OfflineAudioContext.h" 39 #include "modules/webaudio/OfflineAudioContext.h"
40 #include "wtf/ArrayBuffer.h" 40 #include "wtf/ArrayBuffer.h"
41 41
42 namespace WebCore { 42 namespace WebCore {
43 43
44 v8::Handle<v8::Value> V8AudioContext::constructorCustom(const v8::Arguments& arg s) 44 void V8AudioContext::constructorCustom(const v8::FunctionCallbackInfo<v8::Value> & args)
45 { 45 {
46 Document* document = currentDocument(); 46 Document* document = currentDocument();
47 47
48 RefPtr<AudioContext> audioContext; 48 RefPtr<AudioContext> audioContext;
49 49
50 if (!args.Length()) { 50 if (!args.Length()) {
51 // Constructor for default AudioContext which talks to audio hardware. 51 // Constructor for default AudioContext which talks to audio hardware.
52 audioContext = AudioContext::create(document); 52 audioContext = AudioContext::create(document);
53 if (!audioContext.get()) 53 if (!audioContext.get()) {
54 return throwError(v8SyntaxError, "audio resources unavailable for Au dioContext construction", args.GetIsolate()); 54 throwError(v8SyntaxError, "audio resources unavailable for AudioCont ext construction", args.GetIsolate());
55 return;
56 }
55 } else { 57 } else {
56 // Constructor for offline (render-target) AudioContext which renders in to an AudioBuffer. 58 // Constructor for offline (render-target) AudioContext which renders in to an AudioBuffer.
57 // new AudioContext(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate); 59 // new AudioContext(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate);
58 document->addConsoleMessage(JSMessageSource, WarningMessageLevel, 60 document->addConsoleMessage(JSMessageSource, WarningMessageLevel,
59 "Deprecated AudioContext constructor: use OfflineAudioContext instea d"); 61 "Deprecated AudioContext constructor: use OfflineAudioContext instea d");
60 62
61 return V8OfflineAudioContext::constructorCallback(args); 63 V8OfflineAudioContext::constructorCallback(args);
64 return;
62 } 65 }
63 66
64 if (!audioContext.get()) 67 if (!audioContext.get()) {
65 return throwError(v8SyntaxError, "Error creating AudioContext", args.Get Isolate()); 68 throwError(v8SyntaxError, "Error creating AudioContext", args.GetIsolate ());
69 return;
70 }
66 71
67 // Transform the holder into a wrapper object for the audio context. 72 // Transform the holder into a wrapper object for the audio context.
68 v8::Handle<v8::Object> wrapper = args.Holder(); 73 v8::Handle<v8::Object> wrapper = args.Holder();
69 V8DOMWrapper::associateObjectWithWrapper(audioContext.release(), &info, wrap per, args.GetIsolate(), WrapperConfiguration::Dependent); 74 V8DOMWrapper::associateObjectWithWrapper(audioContext.release(), &info, wrap per, args.GetIsolate(), WrapperConfiguration::Dependent);
70 75 args.GetReturnValue().Set(wrapper);
71 return wrapper;
72 } 76 }
73 77
74 } // namespace WebCore 78 } // namespace WebCore
75 79
76 #endif // ENABLE(WEB_AUDIO) 80 #endif // ENABLE(WEB_AUDIO)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698