Issue 1587693002: Avoid parsing and then generating HTML for documents without Dart scripts. This is a fragile workar…

Issue 1587693002: Avoid parsing and then generating HTML for documents without Dart scripts. This is a fragile workar… (Closed)

Created:
4 years, 11 months ago by Jacob

Modified:
4 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Avoid parsing and then generating HTML for documents without Dart scripts. This is a fragile workaround to avoid messing up Angular templates. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b091f4dd413a70797116d51b86c03a13fc65c377

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	lib/src/codegen/html_codegen.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Jacob

The trouble is the existing DOM parser you are using is not stable when it ...

4 years, 11 months ago (2016-01-13 17:55:42 UTC) #2

Jennifer Messerly

The code change LGTM w/ one comment. > The trouble is the existing DOM parser ...

4 years, 11 months ago (2016-01-13 18:05:02 UTC) #3

Jacob

4 years, 11 months ago (2016-01-13 18:55:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b091f4dd413a70797116d51b86c03a13fc65c377 (presubmit successful).