Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1587673014: Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND) (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, yfriedman+watch_chromium.org, vmpstr+watch_chromium.org, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND) (patchset #2 id:20001 of https://codereview.chromium.org/1590243003/ ) Reason for revert: mysterious compile errors on Android appeared two builds after this landed. https://build.chromium.org/p/chromium/builders/Android/builds/50690 Original issue's description: > [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND) > > This is a reland of https://codereview.chromium.org/1581563003 > > BUG=272790 > TBR=thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org > > Committed: https://crrev.com/ab450c5ede0635194331286088d0f488f4086ba5 > Cr-Commit-Position: refs/heads/master@{#369815} TBR=agrieve@chromium.org,thakis@chromium.org,yfriedman@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=272790 Committed: https://crrev.com/1c4276c2ef480164f6cef4d79e98ffcebadea44d Cr-Commit-Position: refs/heads/master@{#369864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -275 lines) Patch
M base/BUILD.gn View 3 chunks +5 lines, -4 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +2 lines, -2 lines 0 comments Download
D base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java View 1 chunk +0 lines, -114 lines 0 comments Download
M base/android/java/templates/ChromiumMultiDex.template View 1 chunk +104 lines, -11 lines 0 comments Download
M base/base.gyp View 4 chunks +4 lines, -10 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/gyp/configure_multidex.py View 2 chunks +9 lines, -41 lines 0 comments Download
M build/android/java_cpp_template.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/pylib/remote/device/dummy/dummy.gyp View 2 chunks +1 line, -23 lines 0 comments Download
M build/apk_browsertest.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/apk_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 2 chunks +2 lines, -19 lines 0 comments Download
M build/java_apk.gypi View 5 chunks +10 lines, -41 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 2 chunks +0 lines, -3 lines 0 comments Download
M testing/test.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jbudorick
Created Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. (RELAND)
4 years, 11 months ago (2016-01-15 22:19:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587673014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587673014/1
4 years, 11 months ago (2016-01-15 22:20:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 22:21:24 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 22:22:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c4276c2ef480164f6cef4d79e98ffcebadea44d
Cr-Commit-Position: refs/heads/master@{#369864}

Powered by Google App Engine
This is Rietveld 408576698