Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1587673005: Add counters for <menuitem>. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add counters for <menuitem>. - UseCounter::MenuItemElement Counts menuitem element usage. if chrome://flags/#enable-experimental-web-platform-features is enabled, HTMLMenuItemElement is used. Otherwise, HTMLUnknownElement is used. - UseCounter::MenuItemCloseTag Counts </menuitem>. <menuitem> is a void element according to the current specification. This counts wrong usages like crbug.com/412945. BUG=412945 Committed: https://crrev.com/960e27eea0a509153ee247d7edda7d1c4d49eb53 Cr-Commit-Position: refs/heads/master@{#369354}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
tkent
yosin, would you review this please?
4 years, 11 months ago (2016-01-14 04:29:26 UTC) #6
yosin_UTC9
lgtm
4 years, 11 months ago (2016-01-14 04:50:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587673005/20001
4 years, 11 months ago (2016-01-14 04:51:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 05:48:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587673005/20001
4 years, 11 months ago (2016-01-14 05:51:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-14 06:48:09 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 06:49:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/960e27eea0a509153ee247d7edda7d1c4d49eb53
Cr-Commit-Position: refs/heads/master@{#369354}

Powered by Google App Engine
This is Rietveld 408576698