Enable the snapshot cache on iPad when the tab switcher is enabled.

Enable the snapshot cache on iPad when the tab switcher is enabled.

BUG=576269
Committed: https://crrev.com/c458c18bf81d581ee1ed7feb81b4efd1365cbab0
Cr-Commit-Position: refs/heads/master@{#369418}

[jbbegue (google), 2016-01-13 16:00:58]

jbbegue@google.com changed reviewers:
+ jbbegue@google.com, msarda@chromium.org

[jbbegue (google), 2016-01-13 16:00:59]

PTAL

[msarda, 2016-01-13 16:25:27]

lgtm

https://codereview.chromium.org/1587663002/diff/1/ios/chrome/browser/snapshot...
File ios/chrome/browser/snapshots/snapshot_cache.mm (right):

https://codereview.chromium.org/1587663002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache.mm:148: if
(experimental_flags::IsTabSwitcherEnabled() ||
As discussed offline, this will potentially exclude from LRUSnapshotCacheEnabled
finch experiment all iPad devices that have tab switcher enabled (function
IsLRUSnapshotCacheEnabled is only called here
https://code.google.com/p/chromium/codesearch#search/&q=IsLRUSnapshotCacheEna...).

https://codereview.chromium.org/1587663002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache.mm:214: if (IsIPadIdiom() &&
!experimental_flags::IsTabSwitcherEnabled())
Optional: Consider adding a function IsCacheEnabled that returns !IsIPadIdiom()
|| experimental_flags::IsTabSwitcherEnabled() and use it everywhere is this
file.

[jbbegue (google), 2016-01-14 12:38:24]

https://codereview.chromium.org/1587663002/diff/1/ios/chrome/browser/snapshot...
File ios/chrome/browser/snapshots/snapshot_cache.mm (right):

https://codereview.chromium.org/1587663002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache.mm:148: if
(experimental_flags::IsTabSwitcherEnabled() ||
On 2016/01/13 16:25:27, msarda wrote:
> As discussed offline, this will potentially exclude from
LRUSnapshotCacheEnabled
> finch experiment all iPad devices that have tab switcher enabled (function
> IsLRUSnapshotCacheEnabled is only called here
>
https://code.google.com/p/chromium/codesearch#search/&q=IsLRUSnapshotCacheEna...).

This is what we want. The iPad should only use the cache with LRU, without it,
it would take too much memory.

https://codereview.chromium.org/1587663002/diff/1/ios/chrome/browser/snapshot...
ios/chrome/browser/snapshots/snapshot_cache.mm:214: if (IsIPadIdiom() &&
!experimental_flags::IsTabSwitcherEnabled())
On 2016/01/13 16:25:27, msarda wrote:
> Optional: Consider adding a function IsCacheEnabled that returns
!IsIPadIdiom()
> || experimental_flags::IsTabSwitcherEnabled() and use it everywhere is this
> file.

You are right I'll do that in another CL.

[jbbegue (google), 2016-01-14 12:38:27]

The CQ bit was checked by jbbegue@google.com

[commit-bot: I haz the power, 2016-01-14 12:38:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587663002/1

[commit-bot: I haz the power, 2016-01-14 12:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 12:46:44]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jbbegue (google), 2016-01-14 15:23:26]

The CQ bit was checked by jbbegue@google.com

[jbbegue (google), 2016-01-14 15:23:26]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/1587663002/#ps20001
(title: "Fixed tests.")

[commit-bot: I haz the power, 2016-01-14 15:24:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587663002/20001

[commit-bot: I haz the power, 2016-01-14 15:34:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 15:36:27]

Description was changed from

==========
Enable the snapshot cache on iPad when the tab switcher is enabled.

BUG=576269
==========

to

==========
Enable the snapshot cache on iPad when the tab switcher is enabled.

BUG=576269

Committed: https://crrev.com/c458c18bf81d581ee1ed7feb81b4efd1365cbab0
Cr-Commit-Position: refs/heads/master@{#369418}
==========

[commit-bot: I haz the power, 2016-01-14 15:36:28]

Patchset 2 (id:??) landed as
https://crrev.com/c458c18bf81d581ee1ed7feb81b4efd1365cbab0
Cr-Commit-Position: refs/heads/master@{#369418}