Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1587653002: Adding Keygen to Policy List (Closed)

Created:
4 years, 11 months ago by svaldez
Modified:
4 years, 11 months ago
CC:
chromium-reviews, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Keygen to Policy List Adding the Keygen setting to the Policy Configuration list. BUG=514767 Committed: https://crrev.com/b4ac7fc14dfc0e46607defb902cad59623cef55b Cr-Commit-Position: refs/heads/master@{#370343}

Patch Set 1 #

Patch Set 2 : Adding to policy files. #

Patch Set 3 : Fix upstream. #

Total comments: 12

Patch Set 4 : Fixing tags and testcases. #

Total comments: 5

Patch Set 5 : Fixing nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -3 lines) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/data/chromeos/enterprise/policies View 1 8 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 2 3 2 chunks +50 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 3 4 3 chunks +73 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (9 generated)
svaldez
Hi, There is a new content setting for key generation using <keygen> that I forgot ...
4 years, 11 months ago (2016-01-13 15:18:52 UTC) #2
svaldez
This is the CL to add policy switches for the keygen UI. It currently supports ...
4 years, 11 months ago (2016-01-14 15:24:41 UTC) #4
Ryan Sleevi
https://codereview.chromium.org/1587653002/diff/40001/chrome/test/data/policy/policy_test_cases.json File chrome/test/data/policy/policy_test_cases.json (right): https://codereview.chromium.org/1587653002/diff/40001/chrome/test/data/policy/policy_test_cases.json#newcode996 chrome/test/data/policy/policy_test_cases.json:996: "os": ["win", "linux", "mac", "chromeos"], no Android? https://codereview.chromium.org/1587653002/diff/40001/chrome/test/data/policy/policy_test_cases.json#newcode1338 chrome/test/data/policy/policy_test_cases.json:1338: ...
4 years, 11 months ago (2016-01-14 22:09:35 UTC) #6
svaldez
https://codereview.chromium.org/1587653002/diff/40001/chrome/test/data/policy/policy_test_cases.json File chrome/test/data/policy/policy_test_cases.json (right): https://codereview.chromium.org/1587653002/diff/40001/chrome/test/data/policy/policy_test_cases.json#newcode996 chrome/test/data/policy/policy_test_cases.json:996: "os": ["win", "linux", "mac", "chromeos"], On 2016/01/14 22:09:34, Ryan ...
4 years, 11 months ago (2016-01-14 22:12:06 UTC) #7
Andrew T Wilson (Slow)
LGTM if you address my comments. https://codereview.chromium.org/1587653002/diff/60001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/1587653002/diff/60001/components/policy/resources/policy_templates.json#newcode140 components/policy/resources/policy_templates.json:140: # For your ...
4 years, 11 months ago (2016-01-15 11:00:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587653002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587653002/80001
4 years, 11 months ago (2016-01-15 18:22:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/136159)
4 years, 11 months ago (2016-01-15 18:33:16 UTC) #13
svaldez
holte: Could I get OWNERS review for tools/metrics?
4 years, 11 months ago (2016-01-19 14:40:33 UTC) #15
Steven Holte
histograms.xml lgtm
4 years, 11 months ago (2016-01-19 23:05:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587653002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587653002/80001
4 years, 11 months ago (2016-01-20 05:34:03 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-20 08:48:42 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 08:50:36 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b4ac7fc14dfc0e46607defb902cad59623cef55b
Cr-Commit-Position: refs/heads/master@{#370343}

Powered by Google App Engine
This is Rietveld 408576698