media/base/android/media_player_android.h - Issue 15876006: Allow some Android media player implementation to be overridden by embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_android.h

Issue 15876006: Allow some Android media player implementation to be overridden by embedders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed indent Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/media_player_manager_impl.h ('K') | « content/browser/android/media_player_manager_impl.cc ('k') | media/base/android/media_player_android.cc » ('j') | media/base/android/media_player_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_player_android.h

diff --git a/media/base/android/media_player_android.h b/media/base/android/media_player_android.h

index ba6efd6fc004c6d51daed77ff9eca311e5d5d2fa..1124235a4457521b3b2a23f714061a0d4fe610f4 100644

--- a/media/base/android/media_player_android.h

+++ b/media/base/android/media_player_android.h

@@ -75,6 +75,8 @@ class MEDIA_EXPORT MediaPlayerAndroid {

virtual bool CanPause() = 0;

virtual bool CanSeekForward() = 0;

virtual bool CanSeekBackward() = 0;

+ virtual GURL GetUrl();

+ virtual GURL GetFirstPartyForCookies();

bulach 2013/05/29 18:31:23 can these be pure virtuals, or at least move tho t

whywhat 2013/05/29 18:50:12 Nope, not every MediaPlayerAndroid will have a URL

// Methods for DeumxerStreamPlayer.

// Informs DemuxerStreamPlayer that the demuxer is ready.