Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: trunk/src/chrome/browser/importer/ie_importer_browsertest_win.cc

Issue 15876003: Revert 201968 "Revert 201837 "OOP import on Windows."" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/importer/ie_importer_browsertest_win.cc
===================================================================
--- trunk/src/chrome/browser/importer/ie_importer_browsertest_win.cc (revision 201976)
+++ trunk/src/chrome/browser/importer/ie_importer_browsertest_win.cc (working copy)
@@ -30,6 +30,7 @@
#include "base/win/windows_version.h"
#include "chrome/browser/bookmarks/imported_bookmark_entry.h"
#include "chrome/browser/favicon/imported_favicon_usage.h"
+#include "chrome/browser/importer/external_process_importer_host.h"
#include "chrome/browser/importer/ie_importer.h"
#include "chrome/browser/importer/ie_importer_utils_win.h"
#include "chrome/browser/importer/ie_importer_test_registry_overrider_win.h"
@@ -484,8 +485,7 @@
// Starts to import the above settings.
// Deletes itself.
- // TODO(gab): Use ExternalProcessImporterHost on Windows.
- ImporterHost* host = new ImporterHost;
+ ImporterHost* host = new ExternalProcessImporterHost;
TestObserver* observer = new TestObserver();
host->SetObserver(observer);
@@ -561,8 +561,7 @@
// Starts to import the above settings.
// Deletes itself.
- // TODO(gab): Use ExternalProcessImporterHost on Windows.
- ImporterHost* host = new ImporterHost;
+ ImporterHost* host = new ExternalProcessImporterHost;
MalformedFavoritesRegistryTestObserver* observer =
new MalformedFavoritesRegistryTestObserver();
host->SetObserver(observer);

Powered by Google App Engine
This is Rietveld 408576698