Replace six with the current version which passes checklicenses.py.

Replace six with the current version which passes checklicenses.py.

This CL replaces third_party/six/ with the version after this commit:
https://bitbucket.org/gutworth/six/commits/1991f8b5b654f077e773f05695a08e0506b7367f

http://crbug.com/573341

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f53e90d4204fcb1292b4788c9f829ea1f73c7c22

[qyearsley, 2016-01-13 16:48:27]

qyearsley@chromium.org changed reviewers:
+ petrcermak@chromium.org, sullivan@chromium.org

[qyearsley, 2016-01-13 16:55:03]

There's also a copy of six in catapult/third_party/gsutil/third_party/, which
has a separate exception in checklicenses.py. I'm inclined to keep this CL
limited to catapult/third_party/six because it's theoretically possible that
gsutil depends on a separate older version of six.

Related CL in chromium repo: https://codereview.chromium.org/1581853005

[petrcermak, 2016-01-13 16:56:19]

LGTM with one comment.

Thanks for taking care of this!
Petr

https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
File third_party/six/README.chromium (right):

https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
third_party/six/README.chromium:2: URL: https://pypi.python.org/pypi/six
I wonder whether this should be https://bitbucket.org/gutworth/six/ when the
code is taken from there.

[petrcermak, 2016-01-13 16:57:02]

nit: the description should probably say "third_party/six" instead of "siz/"

Petr

[qyearsley, 2016-01-13 17:00:22]

https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
File third_party/six/README.chromium (right):

https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
third_party/six/README.chromium:2: URL: https://pypi.python.org/pypi/six
On 2016/01/13 16:56:19, petrcermak wrote:
> I wonder whether this should be https://bitbucket.org/gutworth/six/ when the
> code is taken from there.

Makes sense; done.

[petrcermak, 2016-01-13 18:21:20]

On 2016/01/13 17:00:22, qyearsley wrote:
>
https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
> File third_party/six/README.chromium (right):
> 
>
https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
> third_party/six/README.chromium:2: URL: https://pypi.python.org/pypi/six
> On 2016/01/13 16:56:19, petrcermak wrote:
> > I wonder whether this should be https://bitbucket.org/gutworth/six/ when the
> > code is taken from there.
> 
> Makes sense; done.

Thanks. Still LGTM.

Not sure you noticed the description nit: The description should probably say
"third_party/six" instead of "six/"

Petr

[qyearsley, 2016-01-13 18:22:14]

Description was changed from

==========
Replace six with the current version which passes checklicenses.py.

This CL replaces six/ with the version after this commit:
https://bitbucket.org/gutworth/six/commits/1991f8b5b654f077e773f05695a08e0506...

http://crbug.com/573341
==========

to

==========
Replace six with the current version which passes checklicenses.py.

This CL replaces third_party/six/ with the version after this commit:
https://bitbucket.org/gutworth/six/commits/1991f8b5b654f077e773f05695a08e0506...

http://crbug.com/573341
==========

[qyearsley, 2016-01-13 18:22:35]

On 2016/01/13 18:21:20, petrcermak wrote:
> On 2016/01/13 17:00:22, qyearsley wrote:
> >
>
https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
> > File third_party/six/README.chromium (right):
> > 
> >
>
https://codereview.chromium.org/1587593003/diff/1/third_party/six/README.chro...
> > third_party/six/README.chromium:2: URL: https://pypi.python.org/pypi/six
> > On 2016/01/13 16:56:19, petrcermak wrote:
> > > I wonder whether this should be https://bitbucket.org/gutworth/six/ when
the
> > > code is taken from there.
> > 
> > Makes sense; done.
> 
> Thanks. Still LGTM.
> 
> Not sure you noticed the description nit: The description should probably say
> "third_party/six" instead of "six/"
> 
> Petr

Ah, just got it, thanks :-)

[qyearsley, 2016-01-13 18:22:39]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-01-13 18:22:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587593003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587593003/20001

[commit-bot: I haz the power, 2016-01-13 18:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 18:30:18]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[qyearsley, 2016-01-13 18:31:36]

On 2016/01/13 18:30:18, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

Need OWNER approval, should have waited for sullivan@ to review ^^

[qyearsley, 2016-01-19 18:52:32]

On 2016/01/13 18:31:36, qyearsley wrote:
> On 2016/01/13 18:30:18, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
> 
> Need OWNER approval, should have waited for sullivan@ to review ^^

Ping Annie for OWNERs stamp

[sullivan, 2016-01-20 18:04:52]

lgtm

[qyearsley, 2016-01-20 18:06:40]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-01-20 18:06:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587593003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587593003/20001

[commit-bot: I haz the power, 2016-01-20 18:40:15]

Description was changed from

==========
Replace six with the current version which passes checklicenses.py.

This CL replaces third_party/six/ with the version after this commit:
https://bitbucket.org/gutworth/six/commits/1991f8b5b654f077e773f05695a08e0506...

http://crbug.com/573341
==========

to

==========
Replace six with the current version which passes checklicenses.py.

This CL replaces third_party/six/ with the version after this commit:
https://bitbucket.org/gutworth/six/commits/1991f8b5b654f077e773f05695a08e0506...

http://crbug.com/573341

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-01-20 18:40:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...