Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1587543003: Adding AstNode::PrettyPrint and AstNode::PrintAst (Closed)

Created:
4 years, 11 months ago by Camillo Bruni
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding AstNode::PrettyPrint and AstNode::PrintAst BUG= Committed: https://crrev.com/b0119907ac8ffb366bb3a9f684a7a38720347523 Cr-Commit-Position: refs/heads/master@{#33323}

Patch Set 1 #

Patch Set 2 : don't generate methods in release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M src/ast/ast.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/ast/ast.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Camillo Bruni
PTAL, after being stuck on where inition would fail I added these two helper methods.
4 years, 11 months ago (2016-01-13 14:27:12 UTC) #2
Dan Ehrenberg
Could you give more details on what problem this is trying to solve?
4 years, 11 months ago (2016-01-13 14:44:57 UTC) #3
Camillo Bruni
On 2016/01/13 at 14:44:57, littledan wrote: > Could you give more details on what problem ...
4 years, 11 months ago (2016-01-14 09:16:11 UTC) #4
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-14 18:18:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587543003/1
4 years, 11 months ago (2016-01-15 10:00:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/12094) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 11 months ago (2016-01-15 10:02:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587543003/20001
4 years, 11 months ago (2016-01-15 10:52:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 11:32:30 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 11:33:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0119907ac8ffb366bb3a9f684a7a38720347523
Cr-Commit-Position: refs/heads/master@{#33323}

Powered by Google App Engine
This is Rietveld 408576698