Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-dx-dy-number-composition.html

Issue 1587533002: Add composition support for SVG Web Animation of x, y, dx, dy attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-dx-dy-number-composition.html
diff --git a/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-pointsAtX-pointsAtY-pointsAtZ-composition.html b/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-dx-dy-number-composition.html
similarity index 62%
copy from third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-pointsAtX-pointsAtY-pointsAtZ-composition.html
copy to third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-dx-dy-number-composition.html
index cec17a5995165d4c990d711aca610e614a8d304e..8be3dce6e6eb9091fee0393d8eb7258b5ccb43e2 100644
--- a/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-pointsAtX-pointsAtY-pointsAtZ-composition.html
+++ b/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-dx-dy-number-composition.html
@@ -2,15 +2,15 @@
<html>
<body>
<template id="target-template">
-<svg width="0" height="0">
-<feSpotLight class="target" />
-</svg>
+ <svg width="0" height="0">
+ <feOffset class="target"></feOffset>
+ </svg>
</template>
<script src="../svg-attribute-interpolation/resources/interpolation-test.js"></script>
<script>
'use strict';
assertAttributeInterpolation({
- property: 'pointsAtX',
+ property: 'dx',
underlying: '3',
from: '1',
fromComposite: 'add',
@@ -24,40 +24,8 @@ assertAttributeInterpolation({
{at: 1, is: 9},
{at: 1.4, is: 11},
]);
-
assertAttributeInterpolation({
- property: 'pointsAtX',
- underlying: '5',
- from: '1',
- fromComposite: 'replace',
- to: '6',
- toComposite: 'add',
-}, [
- {at: -0.4, is: -3},
- {at: 0, is: 1},
- {at: 0.2, is: 3},
- {at: 0.6, is: 7},
- {at: 1, is: 11},
- {at: 1.4, is: 15},
-]);
-
-assertAttributeInterpolation({
- property: 'pointsAtX',
- underlying: '5',
- from: neutralKeyframe,
- to: '10',
- toComposite: 'replace',
-}, [
- {at: -0.4, is: 3},
- {at: 0, is: 5},
- {at: 0.2, is: 6},
- {at: 0.6, is: 8},
- {at: 1, is: 10},
- {at: 1.4, is: 12},
-]);
-
-assertAttributeInterpolation({
- property: 'pointsAtY',
+ property: 'dy',
underlying: '3',
from: '1',
fromComposite: 'add',
@@ -73,7 +41,7 @@ assertAttributeInterpolation({
]);
assertAttributeInterpolation({
- property: 'pointsAtY',
+ property: 'dx',
underlying: '5',
from: '1',
fromComposite: 'replace',
@@ -87,40 +55,8 @@ assertAttributeInterpolation({
{at: 1, is: 11},
{at: 1.4, is: 15},
]);
-
assertAttributeInterpolation({
- property: 'pointsAtY',
- underlying: '5',
- from: neutralKeyframe,
- to: '10',
- toComposite: 'replace',
-}, [
- {at: -0.4, is: 3},
- {at: 0, is: 5},
- {at: 0.2, is: 6},
- {at: 0.6, is: 8},
- {at: 1, is: 10},
- {at: 1.4, is: 12},
-]);
-
-assertAttributeInterpolation({
- property: 'pointsAtZ',
- underlying: '3',
- from: '1',
- fromComposite: 'add',
- to: '6',
- toComposite: 'add',
-}, [
- {at: -0.4, is: 2},
- {at: 0, is: 4},
- {at: 0.2, is: 5},
- {at: 0.6, is: 7},
- {at: 1, is: 9},
- {at: 1.4, is: 11},
-]);
-
-assertAttributeInterpolation({
- property: 'pointsAtZ',
+ property: 'dy',
underlying: '5',
from: '1',
fromComposite: 'replace',
@@ -136,7 +72,21 @@ assertAttributeInterpolation({
]);
assertAttributeInterpolation({
- property: 'pointsAtZ',
+ property: 'dx',
+ underlying: '5',
+ from: neutralKeyframe,
+ to: '10',
+ toComposite: 'replace',
+}, [
+ {at: -0.4, is: 3},
+ {at: 0, is: 5},
+ {at: 0.2, is: 6},
+ {at: 0.6, is: 8},
+ {at: 1, is: 10},
+ {at: 1.4, is: 12},
+]);
+assertAttributeInterpolation({
+ property: 'dy',
underlying: '5',
from: neutralKeyframe,
to: '10',

Powered by Google App Engine
This is Rietveld 408576698