Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 15875020: Add test binary files for Issue 15908002. (Closed)

Created:
7 years, 6 months ago by waffles
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Sorin Jianu
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Add test binary files for Issue 15908002. Since binary files break the try server, and Issue 15908002 would like to use the try server, it is necessary to upload these files separately. BUG=245318

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed an executable bit from a binary file (not sure how it got there). #

Patch Set 3 : Modified commands file format to be a map rather than a list. #

Patch Set 4 : Accidentally wrote "sha1" where I meant "sha256". Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, --10 lines) Patch
A chrome/test/data/components/binary_bsdiff_patch.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/binary_courgette_patch.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/binary_input.bin View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/components/binary_output.bin View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc.pem View 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_binary_file View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_text_file View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_static_text_file View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f0 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f1 View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f2 View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f0 View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f1 View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f2 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f3 View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_binary_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_text_file View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_static_text_file View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad.crx View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
waffles
Hi Carlos, If you think we're going in the right direction with the other CL ...
7 years, 6 months ago (2013-05-29 22:14:00 UTC) #1
cpu_(ooo_6.6-7.5)
Adding rsleevi for pem usage
7 years, 6 months ago (2013-05-30 00:56:31 UTC) #2
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/15875020/diff/1/chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json File chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json (right): https://codereview.chromium.org/15875020/diff/1/chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json#newcode1 chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json:1: [["manifest.json", "1cf8d0b433c09c465994e952a79ff6980c68cc7493609f0233a4634de6276e9c", "create", "f0"], ["a_static_text_file", "806bfdfbf05afab546b3741e84fb1ccffdf75eef8629c24c5f84add2785b7bcc", "copy", "a_static_text_file"], ["a_changing_text_file", ...
7 years, 6 months ago (2013-05-30 00:57:45 UTC) #3
waffles
On 2013/05/30 00:57:45, cpu wrote: > https://codereview.chromium.org/15875020/diff/1/chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json > File > chrome/test/data/components/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json > (right): > > ...
7 years, 6 months ago (2013-05-30 01:10:48 UTC) #4
Ryan Sleevi
Please make sure to add/update the BUG= line to point to an appropriate tracking bug ...
7 years, 6 months ago (2013-05-30 01:59:15 UTC) #5
Ryan Sleevi
lgtm
7 years, 6 months ago (2013-05-30 01:59:39 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
7 years, 6 months ago (2013-05-30 17:26:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/waffles@chromium.org/15875020/1
7 years, 6 months ago (2013-05-30 20:13:16 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/test/data/components/binary_input.bin: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-05-30 20:13:26 UTC) #9
cpu_(ooo_6.6-7.5)
Not sure what happened but could it be that some files don't have the right ...
7 years, 6 months ago (2013-05-30 21:06:30 UTC) #10
waffles
On 2013/05/30 21:06:30, cpu wrote: > Not sure what happened but could it be that ...
7 years, 6 months ago (2013-05-30 21:28:17 UTC) #11
Ryan Sleevi
On 2013/05/30 21:28:17, waffles wrote: > On 2013/05/30 21:06:30, cpu wrote: > > Not sure ...
7 years, 6 months ago (2013-05-30 21:32:14 UTC) #12
waffles
On 2013/05/30 21:32:14, Ryan Sleevi wrote: > On 2013/05/30 21:28:17, waffles wrote: > > On ...
7 years, 6 months ago (2013-05-30 21:42:35 UTC) #13
waffles
On 2013/05/30 21:42:35, waffles wrote: > On 2013/05/30 21:32:14, Ryan Sleevi wrote: > > On ...
7 years, 6 months ago (2013-05-31 00:30:03 UTC) #14
waffles
On 2013/05/31 00:30:03, waffles wrote: > On 2013/05/30 21:42:35, waffles wrote: > > On 2013/05/30 ...
7 years, 6 months ago (2013-05-31 19:41:48 UTC) #15
cpu_(ooo_6.6-7.5)
Ryan, can you dcommit his for him? I have windows and the git to svn ...
7 years, 6 months ago (2013-06-03 19:14:37 UTC) #16
sorin
bump. Sorry for the nag, we appreciate any help submitting this, it is blocking a ...
7 years, 6 months ago (2013-06-04 16:56:26 UTC) #17
Ryan Sleevi
I am unable to land this. The .tar.gz2 file contains just empty files (for both ...
7 years, 6 months ago (2013-06-04 18:28:34 UTC) #18
Ryan Sleevi
7 years, 6 months ago (2013-06-04 21:45:04 UTC) #19

Powered by Google App Engine
This is Rietveld 408576698