Issue 15875019: [Android] Fixed default bookmark shortcut icon dimension on flo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15875019: [Android] Fixed default bookmark shortcut icon dimension on flo. (Closed)

Created:
7 years, 6 months ago by Kibeom Kim (inactive)

Modified:
7 years, 6 months ago

Reviewers:
David Trainor- moved to gerrit, cramya, newt (away)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Fixed default bookmark shortcut icon dimension on flo. Dimensions used to draw bookmark shortcut icon should depend on the resolution of the device (i.e., mdpi, hdpi, ...). This CL added -mdpi, -hdpi, and -xhdpi qualifier to values-sw600dp/dimens.xml so that correct dimensions are selected for the corresponding resolution tablet. Specifically, this corrects the bookmark shortcut icon look on flo, which is values-sw600dp-xhdpi. Tested on Nexus 10, new Nexus 7 and Motorola Xoom. BUG=241380

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -39 lines)			Patch
A +	chrome/android/java/res/values-sw600dp-hdpi/dimens.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/android/java/res/values-sw600dp-mdpi/dimens.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/android/java/res/values-sw600dp-xhdpi/dimens.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/android/java/res/values-sw600dp/dimens.xml	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/android/java/res/values-sw800dp/dimens.xml	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kibeom Kim (inactive)

7 years, 6 months ago (2013-05-29 22:25:11 UTC) #2

I just talked with newt, and we agreed that the better solution is not keeping
dimens.xml separately but just baking the information into the icon images.
(homescreen_bg.png) I'll work on that.

Expand Messages | Collapse Messages