Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1587403002: Max-width, floating infobars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: suppress lint warning about using left/right instead of start/end for shadows Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/infobar_wrapper.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/values/dimens.xml
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
index 3788660e17ee84b761776480aeb38976bd590518..00d0cf1ea322ecfdf1bae56b0fd98a125954f1be 100644
--- a/chrome/android/java/res/values/dimens.xml
+++ b/chrome/android/java/res/values/dimens.xml
@@ -68,12 +68,20 @@
<dimen name="infobar_big_icon_message_size">18sp</dimen>
<!-- Text size of descriptive controls on an infobar. -->
<dimen name="infobar_descriptive_text_size">14sp</dimen>
- <!-- Minimum width of an infobar. -->
- <dimen name="infobar_min_width">220dp</dimen>
<!-- Padding surrounding the infobar. -->
<dimen name="infobar_padding">16dp</dimen>
<!-- Margin between stacked buttons in an infobar. -->
<dimen name="infobar_margin_between_stacked_buttons">24dp</dimen>
+ <!-- Minimum width of an infobar. -->
+ <dimen name="infobar_min_width">220dp</dimen>
+ <!-- Maximum width of an infobar. -->
+ <dimen name="infobar_max_width">600dp</dimen>
+ <!-- Width of side shadows on floating infobars. -->
+ <dimen name="infobar_shadow_width">8dp</dimen>
+ <!-- Height of top shadow on each infobar. -->
+ <dimen name="infobar_shadow_height">8dp</dimen>
+ <!-- Distance that a back infobar peeks out above the front infobar. -->
+ <dimen name="infobar_peeking_height">10dp</dimen>
<!-- Vertical margin applied between groups of controls. -->
<dimen name="infobar_margin_above_control_groups">24dp</dimen>
@@ -90,10 +98,6 @@
<dimen name="infobar_big_icon_size">48dp</dimen>
<dimen name="infobar_big_icon_margin">16dp</dimen>
- <dimen name="infobar_shadow_height">10dp</dimen>
- <dimen name="infobar_peeking_height">10dp</dimen>
- <dimen name="infobar_peeking_height_with_shadow">20dp</dimen>
-
<!-- Contextual search dimensions -->
<dimen name="contextual_search_bar_height">56dp</dimen>
<dimen name="contextual_search_text_size">18sp</dimen>
« no previous file with comments | « chrome/android/java/res/layout/infobar_wrapper.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698