Fixes buggy FPU tests for MIPS hardware.

runtime/vm/simulator_mips.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Declares a Simulator for MIPS instructions if we are not generating a native
 // MIPS binary. This Simulator allows us to run and debug MIPS code generation
 // on regular desktop machines.
 // Dart calls into generated code by "calling" the InvokeDartCode stub,
 // which will start execution in the Simulator or forwards to the real entry
 // on a MIPS HW platform.
@@ skipping 32 matching lines @@
   void set_fregister(FRegister freg, int32_t value);
   void set_fregister_float(FRegister freg, float value);
   void set_fregister_double(FRegister freg, double value);
   void set_fregister_long(FRegister freg, int64_t value);
 
   int32_t get_fregister(FRegister freg) const;
   float get_fregister_float(FRegister freg) const;
   double get_fregister_double(FRegister freg) const;
   int64_t get_fregister_long(FRegister freg) const;
 
+  void set_dregister(DRegister freg, int64_t value);
+  void set_dregister_double(DRegister freg, double value);

[regis, 2013/06/18 08:42:12]

I would expect set_dregister to take a double. The other variant taking an
int64_t could be called set_dregister_bits.

[zra, 2013/06/18 16:47:25]

Done.

+
+  int64_t get_dregister(DRegister freg) const;
+  double get_dregister_double(DRegister freg) const;

[regis, 2013/06/18 08:42:12]

ditto with return types.

[zra, 2013/06/18 16:47:25]

Done.

 
   // Accessor for the pc.
   void set_pc(int32_t value) { pc_ = value; }
   int32_t get_pc() const { return pc_; }
 
   // Accessors for hi, lo registers.
   void set_hi_register(int32_t value) { hi_reg_ = value; }
   void set_lo_register(int32_t value) { lo_reg_ = value; }
   int32_t get_hi_register() const { return hi_reg_; }
   int32_t get_lo_register() const { return lo_reg_; }
@@ skipping 25 matching lines @@
   // stack. The simulator's top_exit_frame_info refers to a C++ frame in the
   // native stack.
   uword top_exit_frame_info() const { return top_exit_frame_info_; }
   void set_top_exit_frame_info(uword value) { top_exit_frame_info_ = value; }
 
   // Call on program start.
   static void InitOnce();
 
   // Dart generally calls into generated code with 5 parameters. This is a
   // convenience function, which sets up the simulator state and grabs the
   // result on return.

[regis, 2013/06/18 08:42:12]

The comment should explain the fp_return parameter.

[zra, 2013/06/18 16:47:25]

Done.

   int64_t Call(int32_t entry,
                int32_t parameter0,
                int32_t parameter1,
                int32_t parameter2,
-               int32_t parameter3);
+               int32_t parameter3,
+               bool fp_return = false);
 
   // Runtime and native call support.
   enum CallKind {
     kRuntimeCall,
     kLeafRuntimeCall,
     kNativeCall
   };
   static uword RedirectExternalReference(uword function, CallKind call_kind);
 
   void Longjmp(uword pc,
@@ skipping 84 matching lines @@
   }
 
   friend class SimulatorDebugger;
   friend class SimulatorSetjmpBuffer;
   DISALLOW_COPY_AND_ASSIGN(Simulator);
 };
 
 }  // namespace dart
 
 #endif  // VM_SIMULATOR_MIPS_H_