Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1587393002: Adding <keygen> Content Setting (Android Resources) (Closed)

Created:
4 years, 11 months ago by svaldez
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding <keygen> Content Setting (Android Resources) This adds the resources for the Android UI for Content Setting. These resources are split out from CL 1432573002. BUG=514767 TBR=newt@chromium.org,yfriedman@chromium.org Committed: https://crrev.com/93c6086b0641d6674e0f0d1b02c787ad0e00aea5 Cr-Commit-Position: refs/heads/master@{#369648}

Patch Set 1 #

Messages

Total messages: 12 (6 generated)
svaldez
These are the resources from https://codereview.chromium.org/1432573002/. There's a trybot-only crash that I'm still trying to ...
4 years, 11 months ago (2016-01-15 00:37:30 UTC) #3
svaldez
4 years, 11 months ago (2016-01-15 00:37:52 UTC) #5
Ryan Sleevi
LGTM Going to say TBR this under the resources-are-OK-to-TBR, and so we can work with ...
4 years, 11 months ago (2016-01-15 00:38:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587393002/1
4 years, 11 months ago (2016-01-15 00:43:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 01:27:56 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 01:29:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93c6086b0641d6674e0f0d1b02c787ad0e00aea5
Cr-Commit-Position: refs/heads/master@{#369648}

Powered by Google App Engine
This is Rietveld 408576698