Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 15873002: Files.app: Keep the background color of top buttons as pressed until it is released. (Closed)

Created:
7 years, 7 months ago by hirono
Modified:
7 years, 7 months ago
Reviewers:
yoshiki, hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Keep the background color of top buttons as pressed until it is released. When the button is in the state of 'active', the shadow effect that makes button look as pressed is enabled. And originally when the buttons is in the state of 'hover' or in the state of 'focused', the background color is changed. But some drag operation let the button's state be 'active' but not 'hover' and not 'focused'. This cause the situation the shadow effect is enabled but the background color is not changed. This CL updateds the CSS selector and when the button is in the state of 'active' as well as original condition, the background color is changed. BUG=243287 TEST=manually R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hirono
Could you check this tiny CL? Thank you very much!
7 years, 7 months ago (2013-05-23 13:26:37 UTC) #1
yoshiki
lgtm
7 years, 7 months ago (2013-05-23 14:31:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15873002/1
7 years, 7 months ago (2013-05-24 00:09:34 UTC) #3
hirono
7 years, 7 months ago (2013-05-24 06:41:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r201987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698