Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1587293002: Prevent clang from doing tail-call elimination in DartEntry::InvokeClosure. (Closed)

Created:
4 years, 11 months ago by rmacnak
Modified:
4 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prevent clang from doing tail-call elimination in DartEntry::InvokeClosure. TEST=language/issue21159_test.dart with --noopt R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/d7209511d53a22e3c02b4f21f2d8f1c21330335a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/vm/dart_entry.cc View 1 chunk +6 lines, -1 line 2 comments Download

Messages

Total messages: 8 (4 generated)
rmacnak
4 years, 11 months ago (2016-01-14 20:45:43 UTC) #4
Florian Schneider
lgtm https://chromiumcodereview.appspot.com/1587293002/diff/1/runtime/vm/dart_entry.cc File runtime/vm/dart_entry.cc (right): https://chromiumcodereview.appspot.com/1587293002/diff/1/runtime/vm/dart_entry.cc#newcode195 runtime/vm/dart_entry.cc:195: // This otherwise unnecessary handle is used to ...
4 years, 11 months ago (2016-01-15 00:46:46 UTC) #5
rmacnak
https://chromiumcodereview.appspot.com/1587293002/diff/1/runtime/vm/dart_entry.cc File runtime/vm/dart_entry.cc (right): https://chromiumcodereview.appspot.com/1587293002/diff/1/runtime/vm/dart_entry.cc#newcode195 runtime/vm/dart_entry.cc:195: // This otherwise unnecessary handle is used to prevent ...
4 years, 11 months ago (2016-01-15 01:00:07 UTC) #6
rmacnak
4 years, 11 months ago (2016-01-15 01:01:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7209511d53a22e3c02b4f21f2d8f1c21330335a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698