base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java - Issue 1587253003: Revert of [Android] Rework multidex and enable multidex for unit_tests_apk.

Side by Side Diff: base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java

Issue 1587253003: Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/BaseChromiumApplication.java ('k') | base/android/java/templates/ChromiumMultiDex.template » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 package org.chromium.base.multidex;

6

7 import android.app.ActivityManager;

8 import android.app.ActivityManager.RunningAppProcessInfo;

9 import android.content.Context;

10 import android.content.pm.ApplicationInfo;

11 import android.content.pm.PackageManager;

12 import android.os.Build;

13 import android.support.multidex.MultiDex;

14

15 import org.chromium.base.Log;

16 import org.chromium.base.VisibleForTesting;

17

18 import java.lang.reflect.InvocationTargetException;

19 import java.lang.reflect.Method;

20

21 /**

22 * Performs multidex installation for non-isolated processes.

23 */

24 public class ChromiumMultiDexInstaller {

25

26 private static final String TAG = "base_multidex";

27

28 /**

29 * Suffix for the meta-data tag in the AndroidManifext.xml that determines w hether loading

30 * secondary dexes should be skipped for a given process name.

31 */

32 private static final String IGNORE_MULTIDEX_KEY = ".ignore_multidex";

33

34 /**

35 * Installs secondary dexes if possible/necessary.

36 *

37 * Isolated processes (e.g. renderer processes) can't load secondary dex fi les on

38 * K and below, so we don't even try in that case.

39 *

40 * In release builds of app apks (as opposed to test apks), this is a no-op because:

41 * - multidex isn't necessary in release builds because we run proguard t here and

42 * thus aren't threatening to hit the dex limit; and

43 * - calling MultiDex.install, even in the absence of secondary dexes, ca uses a

44 * significant regression in start-up time (crbug.com/525695).

45 *

46 * @param context The application context.

47 */

48 @VisibleForTesting

49 public static void install(Context context) {

50 if (!ChromiumMultiDex.isMultidexEnabled()) return;

51

52 // TODO(jbudorick): Back out this version check once support for K & bel ow works.

53 // http://crbug.com/512357

54 if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP

55 && !shouldInstallMultiDex(context)) {

56 Log.i(TAG, "Skipping multidex installation: not needed for process." );

57 } else {

58 MultiDex.install(context);

59 Log.i(TAG, "Completed multidex installation.");

60 }

61 }

62

63 private static String getProcessName(Context context) {

64 try {

65 String currentProcessName = null;

66 int pid = android.os.Process.myPid();

67

68 ActivityManager manager =

69 (ActivityManager) context.getSystemService(Context.ACTIVITY_ SERVICE);

70 for (RunningAppProcessInfo processInfo : manager.getRunningAppProces ses()) {

71 if (processInfo.pid == pid) {

72 currentProcessName = processInfo.processName;

73 break;

74 }

75 }

76

77 return currentProcessName;

78 } catch (SecurityException ex) {

79 return null;

80 }

81 }

82

83 // Determines whether MultiDex should be installed for the current process. Isolated

84 // Processes should skip MultiDex as they can not actually access the files on disk.

85 // Privileged processes need ot have all of their dependencies in the MainDe x for

86 // performance reasons.

87 private static boolean shouldInstallMultiDex(Context context) {

88 try {

89 Method isIsolatedMethod =

90 android.os.Process.class.getMethod("isIsolated");

91 Object retVal = isIsolatedMethod.invoke(null);

92 if (retVal != null && retVal instanceof Boolean && ((Boolean) retVal )) {

93 return false;

94 }

95 } catch (IllegalAccessException \| IllegalArgumentException

96 \| InvocationTargetException \| NoSuchMethodException e) {

97 // Ignore and fall back to checking the app processes.

98 }

99

100 String currentProcessName = getProcessName(context);

101 if (currentProcessName == null) return true;

102

103 PackageManager packageManager = context.getPackageManager();

104 try {

105 ApplicationInfo appInfo = packageManager.getApplicationInfo(context. getPackageName(),

106 PackageManager.GET_META_DATA);

107 if (appInfo == null \|\| appInfo.metaData == null) return true;

108 return !appInfo.metaData.getBoolean(currentProcessName + IGNORE_MULT IDEX_KEY, false);

109 } catch (PackageManager.NameNotFoundException e) {

110 return true;

111 }

112 }

113

114 }

OLD	NEW