Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 158723003: drive: Add tests for FileSystem methods (Closed)

Created:
6 years, 10 months ago by hashimoto
Modified:
6 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

drive: Add tests for FileSystem methods There are tests for each operation and each sync performer. But, no test verifies operation classes and performer classes working together. Add tests for FileSystem::Copy(), Move(), Remove(), CreateDirectory(), CreateFile(), TouchFile() and TruncateFile(). BUG=340210 TEST=unit_tests --gtest_filter="FileSystemTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252041

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change parent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -0 lines) Patch
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 2 chunks +221 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hashimoto
6 years, 10 months ago (2014-02-10 10:03:35 UTC) #1
kinaba
https://codereview.chromium.org/158723003/diff/1/chrome/browser/chromeos/drive/file_system_unittest.cc File chrome/browser/chromeos/drive/file_system_unittest.cc (right): https://codereview.chromium.org/158723003/diff/1/chrome/browser/chromeos/drive/file_system_unittest.cc#newcode347 chrome/browser/chromeos/drive/file_system_unittest.cc:347: TEST_F(FileSystemTest, Move) { Could you also test the case ...
6 years, 10 months ago (2014-02-11 00:31:59 UTC) #2
hashimoto
https://codereview.chromium.org/158723003/diff/1/chrome/browser/chromeos/drive/file_system_unittest.cc File chrome/browser/chromeos/drive/file_system_unittest.cc (right): https://codereview.chromium.org/158723003/diff/1/chrome/browser/chromeos/drive/file_system_unittest.cc#newcode347 chrome/browser/chromeos/drive/file_system_unittest.cc:347: TEST_F(FileSystemTest, Move) { On 2014/02/11 00:31:59, kinaba wrote: > ...
6 years, 10 months ago (2014-02-19 07:01:33 UTC) #3
kinaba
lgtm
6 years, 10 months ago (2014-02-19 07:10:20 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 10 months ago (2014-02-19 07:10:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/158723003/70001
6 years, 10 months ago (2014-02-19 07:11:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/158723003/70001
6 years, 10 months ago (2014-02-19 14:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/158723003/70001
6 years, 10 months ago (2014-02-19 15:26:15 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:34:00 UTC) #9
Message was sent while issue was closed. 
Change committed as 252041

Powered by Google App Engine
This is Rietveld 408576698