Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1587193004: Revert of Clear the BLE services list on disconnect. (Closed)

Created:
4 years, 11 months ago by scheib
Modified:
4 years, 11 months ago
Reviewers:
ortuno, armansito, tommyt
CC:
chromium-reviews, darin-cc_chromium.org, jam, perja, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clear the BLE services list on disconnect. (patchset #4 id:60001 of https://codereview.chromium.org/1565773002/ ) Reason for revert: bluetooth/getPrimaryService.html is timing out. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=bluetooth%2FgetPrimaryService.html&testType=layout-tests https://code.google.com/p/chromium/issues/detail?id=577936 Original issue's description: > Clear the BLE services list on disconnect. > > This lets us recreate the services list correctly upon the next > reconnect, which fixes some problems with a device we have, which > disconnects automatically after 30 seconds. > > Also reset the services_discovered flag for this device on disconnect. > In order to accomplish this, I had to move this flag from the dispatcher > host to the bluetooth device instance. > > BUG=570804 > > Committed: https://crrev.com/11195385967983a0b5fc3865576a9fa826d51711 > Cr-Commit-Position: refs/heads/master@{#369593} TBR=ortuno@chromium.org,armansito@chromium.org,tommyt@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570804 Committed: https://crrev.com/14ce1e81d27ca586d3386e7d6cd9b91dca5fdecc Cr-Commit-Position: refs/heads/master@{#369684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -75 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 4 chunks +9 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_bluez.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.h View 3 chunks +0 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 2 chunks +1 line, -11 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheib
Created Revert of Clear the BLE services list on disconnect.
4 years, 11 months ago (2016-01-15 05:00:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587193004/1
4 years, 11 months ago (2016-01-15 05:00:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 05:00:58 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 05:02:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14ce1e81d27ca586d3386e7d6cd9b91dca5fdecc
Cr-Commit-Position: refs/heads/master@{#369684}

Powered by Google App Engine
This is Rietveld 408576698