Source/core/dom/ContainerNodeAlgorithms.h - Issue 15871005: Avoid N^2 walk placing renderers when building the render tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNodeAlgorithms.h

Issue 15871005: Avoid N^2 walk placing renderers when building the render tree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Merging ToT Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/cache/subresource-expiration-1-expected.txt ('K') | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/ContainerNodeAlgorithms.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ContainerNodeAlgorithms.h

diff --git a/Source/core/dom/ContainerNodeAlgorithms.h b/Source/core/dom/ContainerNodeAlgorithms.h

index 5e09a6b5255e434963d940634226bd6522e943f3..d591b77ea79170b99cf7acb08ed0d16375cc3ded 100644

--- a/Source/core/dom/ContainerNodeAlgorithms.h

+++ b/Source/core/dom/ContainerNodeAlgorithms.h

@@ -219,14 +219,15 @@ inline void ChildNodeInsertionNotifier::notify(Node* node)

RefPtr<Document> protectDocument(node->document());

RefPtr<Node> protectNode(node);

+ InsertionCallbackDeferer insertionCallbackDeferer;

if (m_insertionPoint->inDocument())

notifyNodeInsertedIntoDocument(node);

else if (node->isContainerNode())

notifyNodeInsertedIntoTree(toContainerNode(node));

- for (size_t i = 0; i < m_postInsertionNotificationTargets.size(); ++i)

- m_postInsertionNotificationTargets[i]->didNotifySubtreeInsertions(m_insertionPoint);

+ for (size_t i = m_postInsertionNotificationTargets.size(); i; --i)

+ m_postInsertionNotificationTargets[i - 1]->didNotifySubtreeInsertions(m_insertionPoint);

}