Source/core/css/SelectorChecker.h - Issue 15871005: Avoid N^2 walk placing renderers when building the render tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/SelectorChecker.h

Issue 15871005: Avoid N^2 walk placing renderers when building the render tree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reversing the snapshotting logic to fix a bug, and updating test expectations. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/cache/subresource-expiration-2-expected.txt ('k') | Source/core/css/SelectorChecker.cpp » ('j') | Source/core/css/SelectorChecker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/SelectorChecker.h

diff --git a/Source/core/css/SelectorChecker.h b/Source/core/css/SelectorChecker.h

index 2b192e755d1478e5457e0a306bec3f0eb35af2c2..30b7f9edc4fb10df2e63182f98341d36533e7ead 100644

--- a/Source/core/css/SelectorChecker.h

+++ b/Source/core/css/SelectorChecker.h

@@ -58,7 +58,7 @@ public:

struct SelectorCheckingContext {

// Initial selector constructor

- SelectorCheckingContext(const CSSSelector* selector, Element* element, VisitedMatchType visitedMatchType)

+ SelectorCheckingContext(const CSSSelector* selector, Element* element, VisitedMatchType visitedMatchType, int childIndex = 0)

: selector(selector)

, element(element)

, scope(0)

@@ -71,6 +71,7 @@ public:

, hasScrollbarPseudo(false)

, hasSelectionPseudo(false)

, behaviorAtBoundary(DoesNotCrossBoundary)

+ , childIndex(childIndex)

{ }

const CSSSelector* selector;

@@ -85,6 +86,7 @@ public:

bool hasScrollbarPseudo;

bool hasSelectionPseudo;

BehaviorAtBoundary behaviorAtBoundary;

+ int childIndex;

};

template<typename SiblingTraversalStrategy>