Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 15871005: Avoid N^2 walk placing renderers when building the render tree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reversing the snapshotting logic to fix a bug, and updating test expectations. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 1653 matching lines...) Expand 10 before | Expand all | Expand 10 after
1664 if ((change == Force) || (shouldDisplaySeamlesslyWithParent() && (change >= Inherit))) { 1664 if ((change == Force) || (shouldDisplaySeamlesslyWithParent() && (change >= Inherit))) {
1665 // style selector may set this again during recalc 1665 // style selector may set this again during recalc
1666 m_hasNodesWithPlaceholderStyle = false; 1666 m_hasNodesWithPlaceholderStyle = false;
1667 1667
1668 RefPtr<RenderStyle> documentStyle = StyleResolver::styleForDocument( this, m_styleResolver ? m_styleResolver->fontSelector() : 0); 1668 RefPtr<RenderStyle> documentStyle = StyleResolver::styleForDocument( this, m_styleResolver ? m_styleResolver->fontSelector() : 0);
1669 StyleChange ch = Node::diff(documentStyle.get(), renderer()->style() , this); 1669 StyleChange ch = Node::diff(documentStyle.get(), renderer()->style() , this);
1670 if (ch != NoChange) 1670 if (ch != NoChange)
1671 renderer()->setStyle(documentStyle.release()); 1671 renderer()->setStyle(documentStyle.release());
1672 } 1672 }
1673 1673
1674 for (Node* n = firstChild(); n; n = n->nextSibling()) { 1674 for (Node* n = lastChild(); n; n = n->previousSibling()) {
1675 if (!n->isElementNode()) 1675 if (!n->isElementNode())
1676 continue; 1676 continue;
1677 Element* element = toElement(n); 1677 Element* element = toElement(n);
1678 if (shouldRecalcStyle(change, element)) 1678 if (shouldRecalcStyle(change, element))
1679 element->recalcStyle(change); 1679 element->recalcStyle(change);
1680 } 1680 }
1681 1681
1682 if (view()) 1682 if (view())
1683 view()->updateCompositingLayersAfterStyleChange(); 1683 view()->updateCompositingLayersAfterStyleChange();
1684 1684
(...skipping 3929 matching lines...) Expand 10 before | Expand all | Expand 10 after
5614 return; 5614 return;
5615 5615
5616 Vector<RefPtr<Element> > associatedFormControls; 5616 Vector<RefPtr<Element> > associatedFormControls;
5617 copyToVector(m_associatedFormControls, associatedFormControls); 5617 copyToVector(m_associatedFormControls, associatedFormControls);
5618 5618
5619 frame()->page()->chrome().client()->didAssociateFormControls(associatedFormC ontrols); 5619 frame()->page()->chrome().client()->didAssociateFormControls(associatedFormC ontrols);
5620 m_associatedFormControls.clear(); 5620 m_associatedFormControls.clear();
5621 } 5621 }
5622 5622
5623 } // namespace WebCore 5623 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698