Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Issue 1587073011: Plumb NotifyAnimationAborted from the compositor to blink animation delegate. (Closed)

Created:
4 years, 11 months ago by ymalik
Modified:
4 years, 11 months ago
Reviewers:
ajuma, Rick Byers
CC:
chromium-reviews, shans, blink-reviews-platform-graphics_chromium.org, dshwang, vmpstr+blinkwatch_chromium.org, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews, blink-reviews-api_chromium.org, Eric Willigers, cc-bugs_chromium.org, rjwright, jbroman, pdr+graphicswatchlist_chromium.org, darktears, Stephen Chennney, blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, f(malita), danakj+watch_chromium.org, skobes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb NotifyAnimationAborted from the compositor to blink animation delegate. This is needed to clear the blink scroll animator state when an animation started on the MT is cancelled by the compositor. TESTED=forced MT animation to abort from the compositor and verified that the delegate override on the blink side is called. BUG=576438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/73f33b9bb4e534d75915757b7bf746349f817663 Cr-Commit-Position: refs/heads/master@{#369856}

Patch Set 1 #

Total comments: 1

Patch Set 2 : initialize aborted_ in unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -1 line) Patch
M cc/animation/animation_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/animation/animation_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/animation/animation_player.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/animation/animation_player.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/animation/element_animations.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 4 chunks +16 lines, -1 line 0 comments Download
M cc/blink/web_compositor_animation_player_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_to_cc_animation_delegate_adapter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/blink/web_to_cc_animation_delegate_adapter.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/test/test_hooks.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebCompositorAnimationDelegate.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ymalik
4 years, 11 months ago (2016-01-15 16:01:57 UTC) #4
ajuma
lgtm with nit https://codereview.chromium.org/1587073011/diff/1/cc/animation/layer_animation_controller_unittest.cc File cc/animation/layer_animation_controller_unittest.cc (right): https://codereview.chromium.org/1587073011/diff/1/cc/animation/layer_animation_controller_unittest.cc#newcode1033 cc/animation/layer_animation_controller_unittest.cc:1033: : started_(false), finished_(false), start_time_(base::TimeTicks()) {} aborted_ ...
4 years, 11 months ago (2016-01-15 16:49:54 UTC) #6
ymalik
+bokan for Source/web/ +rbyers for public/platform/ +jbroman for Source/platform/
4 years, 11 months ago (2016-01-15 17:30:49 UTC) #8
ymalik
On 2016/01/15 17:30:49, ymalik1 wrote: > +bokan for Source/web/ > +rbyers for public/platform/ > +jbroman ...
4 years, 11 months ago (2016-01-15 17:39:44 UTC) #10
Rick Byers
WebKit LGTM I see there's no test coverage of the WebKit side of this, but ...
4 years, 11 months ago (2016-01-15 19:55:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587073011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587073011/20001
4 years, 11 months ago (2016-01-15 20:35:57 UTC) #14
ymalik
On 2016/01/15 19:55:13, Rick Byers wrote: > WebKit LGTM > > I see there's no ...
4 years, 11 months ago (2016-01-15 20:36:57 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 21:59:54 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 22:00:56 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73f33b9bb4e534d75915757b7bf746349f817663
Cr-Commit-Position: refs/heads/master@{#369856}

Powered by Google App Engine
This is Rietveld 408576698