Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1587073006: New VS 2015 package and copy ucrtbased.dll (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New VS 2015 package and copy ucrtbased.dll This switches the VS 2015 package to one that includes the UCRT installers, and it copies ucrtbased.dll to debug directories so that debug binaries will run. The new VS 2015 package was created using the changes in crrev.com/1588673004. This package was created on a clean VM in hopes of making it reproducible. The steps to create it are: Install Windows 7 Professional, 64-bit Install VS 2015 Professional Update 1. Select custom install and these minimum options: - Visual C++ (which selects three sub-categories including MFC) - Universal Windows App Development Tools - Tools (1.2) and Windows 10 SDK (10.0.10586) Then download the Windows 10 SDK. The version must match the one installed with VS 2015 Update 1 or else there will be warnings about the need to uninstall the previous version. Select "Debugging Tools for Windows" in addition to the defaults (Windows App Certification Kit, Windows Software Development Kit). Note, however, that this just downloads the installers. A message will suggest that running setup.exe will install the requested components but actually you have to go into the Downloads\Windows Kits\10\StandaloneSDK\Installers directory to run the x86 and x64 debugger installers. Then download three copies of update 2999226, the Windows 10 Universal C Runtime, for 64-bit Windows 7, Windows 8, and Windows 8.1. Leave these in the downloads folder. This URl contains the download links: https://support.microsoft.com/en-us/kb/2999226 Then install depot_tools and run: > python depot_tools\win_toolchain\package_from_installed.py 2015 Then upload the package with this syntax (replace hash.zip): > python depot_tools\third_party\gsutil\gsutil cp hash.zip gs://chrome-wintoolchain/hash.zip BUG=440500 Committed: https://crrev.com/51f790c13ee0d450d15eca26c3fb558818b7173d Cr-Commit-Position: refs/heads/master@{#369841}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix line length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/vs_toolchain.py View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
brucedawson
This switches VS 2015 builds to using the new package with the UCRT installers. Details ...
4 years, 11 months ago (2016-01-15 18:37:16 UTC) #3
scottmg
lgtm I look forward to deleting a whole bunch of this goop for 2013 once ...
4 years, 11 months ago (2016-01-15 19:19:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587073006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587073006/20001
4 years, 11 months ago (2016-01-15 20:57:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 21:18:14 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 21:19:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/51f790c13ee0d450d15eca26c3fb558818b7173d
Cr-Commit-Position: refs/heads/master@{#369841}

Powered by Google App Engine
This is Rietveld 408576698