Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1587053004: Use out-of-tree build directory for pnacl build (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 11 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Use out-of-tree build directory for pnacl build This should allow use to build with other toolchains without clobbering the build each time. R=bradnelson@chromium.org Committed: https://chromium.googlesource.com/webports/+/1c2183a8b92dda3f44b2d9448e48305b0cdfc582

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M build_tools/common.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ports/pnacl/build.sh View 1 6 chunks +39 lines, -27 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
Sam Clegg
4 years, 11 months ago (2016-01-15 20:27:39 UTC) #3
bradnelson
lgtm
4 years, 11 months ago (2016-01-15 21:07:09 UTC) #4
Sam Clegg
4 years, 11 months ago (2016-01-15 23:16:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1c2183a8b92dda3f44b2d9448e48305b0cdfc582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698