Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1587053003: Don't inline methods that only throw. (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : revert #

Patch Set 4 : baseline #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pkg/compiler/lib/src/cps_ir/inline.dart View 1 3 1 chunk +7 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sra1
4 years, 11 months ago (2016-01-14 22:15:06 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1587053003/diff/1/pkg/compiler/lib/src/cps_ir/inline.dart File pkg/compiler/lib/src/cps_ir/inline.dart (right): https://codereview.chromium.org/1587053003/diff/1/pkg/compiler/lib/src/cps_ir/inline.dart#newcode376 pkg/compiler/lib/src/cps_ir/inline.dart:376: // that throw an exception. The throw sequence ...
4 years, 11 months ago (2016-01-14 22:50:51 UTC) #3
sra1
Committed patchset #2 (id:20001) manually as 033d78c579eebb81a0881951633d95188ee93dcc (presubmit successful).
4 years, 11 months ago (2016-01-14 22:54:35 UTC) #5
sra1
Committed patchset #3 (id:40001) manually as 890e900c3100daf34e08cba632d277101eec18bc (presubmit successful).
4 years, 11 months ago (2016-01-15 05:20:35 UTC) #8
sra1
4 years, 11 months ago (2016-01-15 19:35:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
d7237c5275475c6a5b48d682125e6738a9d930a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698