Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1587043002: Update changelog with information in WebSocket compression (Closed)

Created:
4 years, 11 months ago by Søren Gjesse
Modified:
4 years, 11 months ago
Reviewers:
mit
CC:
reviews_dartlang.org, kevmoo
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Søren Gjesse
4 years, 11 months ago (2016-01-14 10:24:06 UTC) #2
mit
On 2016/01/14 10:24:06, Søren Gjesse wrote: LGTM We should cherry pick this
4 years, 11 months ago (2016-01-14 10:42:54 UTC) #3
mit
LGTM We should cherry pick this https://codereview.chromium.org/1587043002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1587043002/diff/1/CHANGELOG.md#newcode34 CHANGELOG.md:34: `WebSocketTransformer` constructor is ...
4 years, 11 months ago (2016-01-14 10:43:19 UTC) #4
Søren Gjesse
https://codereview.chromium.org/1587043002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1587043002/diff/1/CHANGELOG.md#newcode34 CHANGELOG.md:34: `WebSocketTransformer` constructor is used to select the compression On ...
4 years, 11 months ago (2016-01-14 14:54:21 UTC) #5
Søren Gjesse
4 years, 11 months ago (2016-01-14 14:55:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4e35dd3b05ac9b05c9987d3b870b5e7ee10cb217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698