third_party/WebKit/LayoutTests/svg/custom/object-sizing-zero-intrinsic-width-height-expected.html - Issue 1587023002: SVG with zero intrinsic size should be respected always

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/object-sizing-zero-intrinsic-width-height-expected.html

Issue 1587023002: SVG with zero intrinsic size should be respected always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/custom/object-sizing-zero-intrinsic-width-height.html ('K') | « third_party/WebKit/LayoutTests/svg/custom/object-sizing-zero-intrinsic-width-height.html ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body style="margin: 0px; padding: 0px;">

	4 <!--There should not be any red rectangle visible. -->
	davve 2016/01/20 07:54:22 Not sure why you have all these SVGs that's not su Not sure why you have all these SVGs that's not supposed to be visible in the -expected file. Worst case, both <object> and <svg> regress at the same time, in the same way, making the reftest still pass. In general, an expected file should be written as simple as possible (and maybe with different primitives). If you want to test zero dimensions inline SVGs, I'd suggest you add a separate test for that, or make the test more general and test that as well. Shanmuga Pandi 2016/01/20 13:41:40 Ah. My intention of this file is just as the outpu Show quoted text On 2016/01/20 07:54:22, David Vest wrote: > Not sure why you have all these SVGs that's not supposed to be visible in the > -expected file. Worst case, both <object> and <svg> regress at the same time, in > the same way, making the reftest still pass. > > In general, an expected file should be written as simple as possible (and maybe > with different primitives). If you want to test zero dimensions inline SVGs, I'd > suggest you add a separate test for that, or make the test more general and test > that as well. Ah. My intention of this file is just as the output should be same as <object> and <svg> with zero intrinsic. I should keep -expected.html as just empty with just <body> </body>. Will it be fine ? davve 2016/01/20 16:05:19 If you just want an empty file '<!DOCTYPE html>' w Show quoted text On 2016/01/20 13:41:40, Shanmuga Pandi wrote: > On 2016/01/20 07:54:22, David Vest wrote: > > Not sure why you have all these SVGs that's not supposed to be visible in the > > -expected file. Worst case, both <object> and <svg> regress at the same time, > in > > the same way, making the reftest still pass. > > > > In general, an expected file should be written as simple as possible (and > maybe > > with different primitives). If you want to test zero dimensions inline SVGs, > I'd > > suggest you add a separate test for that, or make the test more general and > test > > that as well. > > Ah. My intention of this file is just as the output should be same as <object> > and <svg> with zero intrinsic. > I should keep -expected.html as just empty with just <body> </body>. Will it be > fine ? If you just want an empty file '<!DOCTYPE html>' would do. Shanmuga Pandi 2016/01/28 11:21:57 Done. Show quoted text On 2016/01/20 16:05:19, David Vest wrote: > On 2016/01/20 13:41:40, Shanmuga Pandi wrote: > > On 2016/01/20 07:54:22, David Vest wrote: > > > Not sure why you have all these SVGs that's not supposed to be visible in > the > > > -expected file. Worst case, both <object> and <svg> regress at the same > time, > > in > > > the same way, making the reftest still pass. > > > > > > In general, an expected file should be written as simple as possible (and > > maybe > > > with different primitives). If you want to test zero dimensions inline SVGs, > > I'd > > > suggest you add a separate test for that, or make the test more general and > > test > > > that as well. > > > > Ah. My intention of this file is just as the output should be same as <object> > > and <svg> with zero intrinsic. > > I should keep -expected.html as just empty with just <body> </body>. Will it > be > > fine ? > > If you just want an empty file '<!DOCTYPE html>' would do. Done.
	5 <svg width='0' height='0'>

	6 <rect width='50' height='50' fill='red'/>

	7 </svg>

	8

	9 <svg width='50' height='0'>

	10 <rect width='50' height='50' fill='red'/>

	11 </svg>

	12

	13 <svg width='0' height='50'>

	14 <rect width='50' height='50' fill='red'/>

	15 </svg>

	16 </body>

	17 </html>

OLD	NEW