Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1587013002:
[turbofan] Stage escape analysis (Closed)
|
Created:
4 years, 11 months ago by sigurds Modified:
4 years, 11 months ago Reviewers:
Michael Starzinger CC:
v8-reviews_googlegroups.com, Michael Hablich Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Stage escape analysis
This CL enables escape analysis. We expect performance feedback
and a lot of clusterfuzz bugs.
R=mstarzinger@chromium.org
BUG=v8:4586
LOG=n
Committed: https://crrev.com/2fbe5946ed18cc204fae1ca4b95a812c599a2629
Cr-Commit-Position: refs/heads/master@{#33499}
Patch Set 1 #Patch Set 2 : Use implication. #Messages
Total messages: 18 (6 generated)
I think we should give it a try.
LGTM. Woot!
The CQ bit was checked by sigurds@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587013002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
The CQ bit was checked by sigurds@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587013002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sigurds@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587013002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Stage escape analysis This CL enables escape analysis. We expect performance feedback and a lot of clusterfuzz bugs. R=mstarzinger@chromium.org BUG=v8:4586 LOG=n ========== to ========== [turbofan] Stage escape analysis This CL enables escape analysis. We expect performance feedback and a lot of clusterfuzz bugs. R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Committed: https://crrev.com/2fbe5946ed18cc204fae1ca4b95a812c599a2629 Cr-Commit-Position: refs/heads/master@{#33499} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2fbe5946ed18cc204fae1ca4b95a812c599a2629 Cr-Commit-Position: refs/heads/master@{#33499}
Message was sent while issue was closed.
This adds a huge slow-down on mjsunit/regress/regress-1200351, see: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20... In previous builds it ran in 3 min (which is already slow). Could you speed this up again - or change/skip the test for isolates mode?
Message was sent while issue was closed.
On 2016/01/26 10:26:00, Michael Achenbach wrote: > This adds a huge slow-down on mjsunit/regress/regress-1200351, see: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20... > > In previous builds it ran in 3 min (which is already slow). > > Could you speed this up again - or change/skip the test for isolates mode? FYI: This also causes timeout flakes further down the road: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20...
Message was sent while issue was closed.
On 2016/01/26 11:00:44, Michael Achenbach wrote: > On 2016/01/26 10:26:00, Michael Achenbach wrote: > > This adds a huge slow-down on mjsunit/regress/regress-1200351, see: > > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20... > > > > In previous builds it ran in 3 min (which is already slow). > > > > Could you speed this up again - or change/skip the test for isolates mode? > > FYI: This also causes timeout flakes further down the road: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20... And the duration regression is happening on all debug bots, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds... |
