Issue 15870009: mac: Move more 10.7 api stuff into sdk_forward_declarations.h

Issue 15870009: mac: Move more 10.7 api stuff into sdk_forward_declarations.h (Closed)

Created:
7 years, 6 months ago by Nico

Modified:
7 years, 6 months ago

Reviewers:
Mark Mentovai, scherkus (not reviewing)

CC:
chromium-reviews, James Su, yusukes+watch_chromium.org, feature-media-reviews_chromium.org, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Move more 10.7 api stuff into sdk_forward_declarations.h BUG=none TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205234

Patch Set 1 #

Patch Set 2 : mac: Move more 10.7 api stuff into sdk_forward_declarations.h #

Patch Set 3 : . #

Total comments: 5

Patch Set 4 : comments #

Patch Set 5 : rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -46 lines)			Patch
M	base/mac/sdk_forward_declarations.h	View	1 2 3 4	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_view.mm	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2 3 4	1 chunk	+0 lines, -9 lines	0 comments	Download
M	ui/base/layout_mac.mm	View		1 chunk	+1 line, -12 lines	0 comments	Download
M	ui/gfx/screen_mac.mm	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	ui/snapshot/snapshot_mac_unittest.mm	View		1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Nico

mac: Move more 10.7 api stuff into sdk_forward_declarations.h

7 years, 6 months ago (2013-06-06 02:07:43 UTC) #1

Nico

Mark: Please review. The `git cl upload -m` switch rename means that I can't send ...

7 years, 6 months ago (2013-06-06 02:14:26 UTC) #4

Mark Mentovai

LGTM https://codereview.chromium.org/15870009/diff/2008/base/mac/sdk_forward_declarations.h File base/mac/sdk_forward_declarations.h (right): https://codereview.chromium.org/15870009/diff/2008/base/mac/sdk_forward_declarations.h#newcode13 base/mac/sdk_forward_declarations.h:13: I guess this should #import <AppKit/AppKit.h> for IWYU ...

7 years, 6 months ago (2013-06-06 13:49:57 UTC) #5

Nico

Thanks! https://codereview.chromium.org/15870009/diff/2008/base/mac/sdk_forward_declarations.h File base/mac/sdk_forward_declarations.h (right): https://codereview.chromium.org/15870009/diff/2008/base/mac/sdk_forward_declarations.h#newcode13 base/mac/sdk_forward_declarations.h:13: On 2013/06/06 13:49:57, Mark Mentovai wrote: > I ...

7 years, 6 months ago (2013-06-10 16:54:38 UTC) #6

Nico

Committed patchset #5 manually as r205234 (presubmit successful).

7 years, 6 months ago (2013-06-10 17:12:55 UTC) #10

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages