Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 15870003: Revert 202215 "Migrate the IndexedDB backend from Blink to Chromium" (Closed)

Created:
7 years, 7 months ago by xiyuan
Modified:
7 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202215 "Migrate the IndexedDB backend from Blink to Chromium" > Migrate the IndexedDB backend from Blink to Chromium > > To get the IDB backend off the (deprecated) WebKit thread, remove > intermediate proxying, and let us take advantage of base utilities, > we're moving the code from Blink to Chromium. > > This patch is basically a glorified copy/paste of the Blink IDB > backend code, with Chromium coding style applied, WTF dependencies > replaced with STL and base/, redundant classes removed, etc. It > introduces some new temporary proxy classes > (content/browser/webidb*_impl.*) to allow us build both the old and > new backends. > > The new backend is currently disabled by default. It can be enabled > using a new (and temporary) command line switch: --new-indexeddb Once > we've done some further cleanup and are confident that the new backend > is stable, and the bots have moved from DumpRenderTree to > content_shell, we'll switch to the new backend by default. Once that > has survived through a dev channel release, we'll delete the Blink > code and eliminate unnecessary proxy classes. > > BUG=234278 > R=alecflett@chromium.org, dgrogan@chromium.org, piman@chromium.org > > Review URL: https://codereview.chromium.org/15564008 TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -14712 lines) Patch
M trunk/src/android_webview/tools/third_party_files_whitelist.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/in_process_webkit/indexed_db_database_callbacks.cc View 2 chunks +25 lines, -19 lines 0 comments Download
M trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 7 chunks +15 lines, -13 lines 0 comments Download
M trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 30 chunks +230 lines, -231 lines 0 comments Download
D trunk/src/content/browser/indexed_db/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db.h View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_backing_store.h View 1 chunk +0 lines, -319 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +0 lines, -2513 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 chunk +0 lines, -403 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_callbacks_wrapper.h View 1 chunk +0 lines, -95 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_callbacks_wrapper.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_context_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_context_impl.cc View 15 chunks +34 lines, -50 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_cursor.h View 1 chunk +0 lines, -37 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_cursor_impl.h View 1 chunk +0 lines, -98 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_cursor_impl.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_database.h View 1 chunk +0 lines, -131 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_database_callbacks_wrapper.h View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_database_callbacks_wrapper.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_database_error.h View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_database_impl.h View 1 chunk +0 lines, -204 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_database_impl.cc View 1 chunk +0 lines, -1823 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_factory.h View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_factory_impl.h View 1 chunk +0 lines, -77 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_factory_impl.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_index_writer.h View 1 chunk +0 lines, -82 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_index_writer.cc View 1 chunk +0 lines, -169 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_internals_ui.h View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.h View 1 chunk +0 lines, -467 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.cc View 1 chunk +0 lines, -1880 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc View 1 chunk +0 lines, -748 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_metadata.h View 1 chunk +0 lines, -84 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_metadata.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_quota_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_quota_client.cc View 6 chunks +47 lines, -29 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 10 chunks +34 lines, -24 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_tracing.h View 1 chunk +0 lines, -11 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_transaction.h View 1 chunk +0 lines, -150 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_transaction_coordinator.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/content/browser/indexed_db/indexed_db_transaction_coordinator.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_unittest.cc View 5 chunks +21 lines, -13 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/avltree.h View 1 chunk +0 lines, -979 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/fixed_array.h View 1 chunk +0 lines, -62 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_comparator.h View 1 chunk +0 lines, -24 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_database.h View 1 chunk +0 lines, -75 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_database.cc View 1 chunk +0 lines, -361 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_iterator.h View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_slice.h View 1 chunk +0 lines, -37 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_transaction.h View 1 chunk +0 lines, -179 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_transaction.cc View 1 chunk +0 lines, -490 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_unittest.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_write_batch.h View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/src/content/browser/indexed_db/leveldb/leveldb_write_batch.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D trunk/src/content/browser/indexed_db/list_set.h View 1 chunk +0 lines, -158 lines 0 comments Download
D trunk/src/content/browser/indexed_db/list_set_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D trunk/src/content/browser/indexed_db/webidbcursor_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/content/browser/indexed_db/webidbcursor_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/src/content/browser/indexed_db/webidbdatabase_impl.h View 1 chunk +0 lines, -110 lines 0 comments Download
D trunk/src/content/browser/indexed_db/webidbdatabase_impl.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D trunk/src/content/browser/indexed_db/webidbfactory_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/content/browser/indexed_db/webidbfactory_impl.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M trunk/src/content/common/indexed_db/indexed_db_key.cc View 6 chunks +5 lines, -25 lines 0 comments Download
M trunk/src/content/common/indexed_db/indexed_db_param_traits.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 2 chunks +0 lines, -45 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
7 years, 7 months ago (2013-05-25 15:49:30 UTC) #1
xiyuan
Fails on Windows debug test bots, MS STL vector assertion on index. e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/19053 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%281%29/builds/36237 ...
7 years, 7 months ago (2013-05-25 15:52:10 UTC) #2
xiyuan
Committed patchset #1 manually as r202302.
7 years, 7 months ago (2013-05-25 15:52:23 UTC) #3
jsbell
7 years, 6 months ago (2013-05-28 15:35:32 UTC) #4
Message was sent while issue was closed.
Thanks for the revert - lgtm

Didn't show up on the try bots, but trivially reproduceable with VC++10.

Powered by Google App Engine
This is Rietveld 408576698