Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1586983004: Revert of Scale scrollbar in use-zoom-for-dsf mode (Closed)

Created:
4 years, 11 months ago by huangs
Modified:
4 years, 11 months ago
Reviewers:
skobes, sof, oshima, eae
CC:
chromium-reviews, blink-reviews, cc-bugs_chromium.org, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org, danakj, samuong, vasilii
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Scale scrollbar in use-zoom-for-dsf mode (patchset #9 id:340001 of https://codereview.chromium.org/1560403002/ ) Reason for revert: This is causing oilpan compile errors under Clang: ../../third_party/WebKit/Source/platform/scroll/Scrollbar.h:196:5: note: [blink-gc] Raw pointer field 'm_hostWindow' to a GC managed class declared here: HostWindow* m_hostWindow; Original issue's description: > Scale scrollbar in use-zoom-for-dsf mode > > * Scale the size of scrollbar > * Compute the trackRect in ScrollbarThemeNonMacCommon using width/height of the reference scrollbar to compute thickness, instead of using scrollbarThickness > > BUG=485650 > TEST=manual. Layout test will be covered in a separate CL that adds virtual test suite for this mode. > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/0a1920a7d4dd833fa8cffb4b7acd38b040236326 > Cr-Commit-Position: refs/heads/master@{#369477} TBR=skobes@chromium.org,eae@chromium.org,oshima@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485650 Committed: https://crrev.com/7a6ed5b30840876c7d0e37b942e5bd2fd44ca93c Cr-Commit-Position: refs/heads/master@{#369492}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
huangs
Created Revert of Scale scrollbar in use-zoom-for-dsf mode
4 years, 11 months ago (2016-01-14 19:09:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586983004/1
4 years, 11 months ago (2016-01-14 19:10:23 UTC) #2
huangs
4 years, 11 months ago (2016-01-14 19:11:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 19:12:28 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a6ed5b30840876c7d0e37b942e5bd2fd44ca93c Cr-Commit-Position: refs/heads/master@{#369492}
4 years, 11 months ago (2016-01-14 19:13:18 UTC) #7
sof
https://codereview.chromium.org/1584313003/ has the modifications needed.
4 years, 11 months ago (2016-01-14 19:16:22 UTC) #9
oshima
4 years, 11 months ago (2016-01-14 19:21:54 UTC) #10
Message was sent while issue was closed.
On 2016/01/14 19:16:22, sof wrote:
> https://codereview.chromium.org/1584313003/ has the modifications needed.

Got it. Thank you!

Powered by Google App Engine
This is Rietveld 408576698