Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1586943002: Add cleanup ShrinkingReducer pass after second TypePropagation pass. (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add cleanup ShrinkingReducer pass after second TypePropagation pass. The need for cleanup shows up in co19/LibTest/collection/DoubleLinkedQueue/forEachEntry_A01_t02 The compiler crashed: Internal Error: Unreachable continuations must be removed before computing loop side effects. TBR=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/1aab83e6dd9b2b03f2157beab4a2276e8fd9f321

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
Committed patchset #1 (id:20001) manually as 1aab83e6dd9b2b03f2157beab4a2276e8fd9f321 (presubmit successful).
4 years, 11 months ago (2016-01-14 06:10:57 UTC) #5
sra1
FYI The second TypePropagation pass inlined a single-use closure that had a body that always ...
4 years, 11 months ago (2016-01-14 16:29:54 UTC) #6
asgerf
4 years, 11 months ago (2016-01-14 18:06:53 UTC) #7
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698