Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15869002: Add WebKit plumbing for --enable-pinch-virtual-viewport (Closed)

Created:
7 years, 7 months ago by wjmaclean
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

Add WebKit plumbing for --enable-pinch-virtual-viewport BUG=none R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/WebKit/chromium/public/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/page/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wjmaclean
This will need to land before https://codereview.chromium.org/15567005/
7 years, 7 months ago (2013-05-23 12:42:05 UTC) #1
jamesr
lgtm
7 years, 7 months ago (2013-05-23 16:58:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/15869002/1
7 years, 7 months ago (2013-05-23 17:51:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7038
7 years, 7 months ago (2013-05-23 19:21:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/15869002/1
7 years, 7 months ago (2013-05-23 19:59:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7078
7 years, 7 months ago (2013-05-23 21:43:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/15869002/1
7 years, 7 months ago (2013-05-24 12:42:18 UTC) #7
wjmaclean
7 years, 7 months ago (2013-05-24 14:11:42 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 manually as r151099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698