Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1586893003: Revert of [tracing] Dump child processes' memory metrics in browser (Closed)

Created:
4 years, 11 months ago by huangs
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, darin-cc_chromium.org, jam, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@web_cache2_base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Dump child processes' memory metrics in browser (patchset #15 id:400001 of https://codereview.chromium.org/1417003003/ ) Reason for revert: This is suspected by Findit to cause failure in TracingBrowserTest.TestMemoryInfra under Mac ASan 64 Tests (1). Original issue's description: > [tracing] Dump child processes' memory metrics in browser > > The sandbox in linux prevents the process from reading the process > metrics file. To work around this issue, the browser process will now > dump statistics of the child processes too. This requires the > composable dumps support in trace viewer and telemetry. > > This CL makes following changes. > 1. Move the process totals and memory maps dump provider into a single > header as process_metrics_dump_provider in components/tracing. This is > because it is not necessary to have this in base and now the provider > knows/manages for different processes. Also the dump method are made to > handle error better, since process can vanish while dumping. > > 2. Make the dump provider non-singleton and have a register / unregister > that manages the lifetime of the dump providers. > > 3. The dump providers unregister using the new > UnregisterAndDeleteDumpProviderAsync api added by crrev.com/1430073002. > > 4. On linux the browser process dumps metrics for all processes and on > android the child processes can dump since seccomp sandbox is not > enabled in android yet. > > 5. The proc/status file is human readable stats and is not guaranteed to > have a field that is asked for. So, the NOTREACHED is removed in > ReadProcStatusAndGetFieldAsSizeT. > > 6. Since we introduce other process dumps from browser process there > could be races while unregistering and dumping. To test this, the > browser test is updated. > > BUG=461788 > > Committed: https://crrev.com/4d77d76a42425282b1a3c5b7309db9b98e777f60 > Cr-Commit-Position: refs/heads/master@{#369482} TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,ssid@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461788 Committed: https://crrev.com/93aa967cfcb3e933000f169b9a4f7ac84dbd96da Cr-Commit-Position: refs/heads/master@{#369535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -659 lines) Patch
M base/BUILD.gn View 6 chunks +11 lines, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 2 chunks +18 lines, -0 lines 0 comments Download
A base/trace_event/process_memory_maps_dump_provider.h View 1 chunk +43 lines, -0 lines 0 comments Download
A base/trace_event/process_memory_maps_dump_provider.cc View 1 chunk +176 lines, -0 lines 0 comments Download
A base/trace_event/process_memory_maps_dump_provider_unittest.cc View 1 chunk +190 lines, -0 lines 0 comments Download
A base/trace_event/process_memory_totals_dump_provider.h View 1 chunk +48 lines, -0 lines 0 comments Download
A base/trace_event/process_memory_totals_dump_provider.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A base/trace_event/process_memory_totals_dump_provider_unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M base/trace_event/trace_event.gypi View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 chunk +1 line, -11 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/tracing.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
M components/tracing/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
M components/tracing/child_memory_dump_manager_delegate_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D components/tracing/process_metrics_memory_dump_provider.h View 1 chunk +0 lines, -67 lines 0 comments Download
D components/tracing/process_metrics_memory_dump_provider.cc View 1 chunk +0 lines, -305 lines 0 comments Download
D components/tracing/process_metrics_memory_dump_provider_unittest.cc View 1 chunk +0 lines, -232 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
huangs
Created Revert of [tracing] Dump child processes' memory metrics in browser
4 years, 11 months ago (2016-01-14 20:54:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586893003/1
4 years, 11 months ago (2016-01-14 20:56:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 20:59:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/93aa967cfcb3e933000f169b9a4f7ac84dbd96da Cr-Commit-Position: refs/heads/master@{#369535}
4 years, 11 months ago (2016-01-14 22:03:17 UTC) #5
ssid
4 years, 11 months ago (2016-01-15 01:19:28 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1591553002/ by ssid@chromium.org.

The reason for reverting is: Reland of patch with fix.

Powered by Google App Engine
This is Rietveld 408576698