ios/chrome/browser/bookmarks/bookmark_model_factory.cc - Issue 1586833002: Convert Pass()→std::move() for iOS build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/bookmarks/bookmark_model_factory.cc

Issue 1586833002: Convert Pass()→std::move() for iOS build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert accidental //base change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/bookmarks/bookmark_model_factory.cc

diff --git a/ios/chrome/browser/bookmarks/bookmark_model_factory.cc b/ios/chrome/browser/bookmarks/bookmark_model_factory.cc

index 640dd1f72dbd6b6d836e93a1108a1745532cd653..e386e8c291dcc6c4cad30960ee82c95bdbf34ed5 100644

--- a/ios/chrome/browser/bookmarks/bookmark_model_factory.cc

+++ b/ios/chrome/browser/bookmarks/bookmark_model_factory.cc

@@ -4,6 +4,8 @@

#include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"

+#include <utility>

#include "base/memory/singleton.h"

#include "base/prefs/pref_service.h"

#include "components/bookmarks/browser/bookmark_model.h"

@@ -75,7 +77,7 @@ scoped_ptr<KeyedService> BookmarkModelFactory::BuildServiceInstanceFor(

web::WebThread::GetTaskRunnerForThread(web::WebThread::UI));

ios::BookmarkUndoServiceFactory::GetForBrowserState(browser_state)

->Start(bookmark_model.get());

- return bookmark_model.Pass();

+ return std::move(bookmark_model);

}

web::BrowserState* BookmarkModelFactory::GetBrowserStateToUse(