Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: base/memory/scoped_ptr_unittest.cc

Issue 1586833002: Convert Pass()→std::move() for iOS build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/policy/profile_policy_connector_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/scoped_ptr_unittest.cc
diff --git a/base/memory/scoped_ptr_unittest.cc b/base/memory/scoped_ptr_unittest.cc
index 4f0e78425fe74a5d6434f81004f7f223a541be02..0fff33c0e2d458247b84cece8dfbf0176e0c716a 100644
--- a/base/memory/scoped_ptr_unittest.cc
+++ b/base/memory/scoped_ptr_unittest.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include <sstream>
+#include <utility>
#include "base/bind.h"
#include "base/callback.h"
@@ -412,7 +413,7 @@ TEST(ScopedPtrTest, MoveBehavior) {
EXPECT_EQ(1, constructed);
// Should auto-destruct logger by end of scope.
- scoped_ptr<ConDecLogger>&& rvalue = scoper.Pass();
+ scoped_ptr<ConDecLogger>&& rvalue = std::move(scoper);
dcheng 2016/01/14 00:37:51 Oops, this got included by accident. I've reverted
// The Pass() function mimics std::move(), which does not have side-effects.
EXPECT_TRUE(scoper.get());
EXPECT_TRUE(rvalue);
« no previous file with comments | « no previous file | chrome/browser/policy/profile_policy_connector_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698