Convert Pass()→std::move() for iOS build.

Convert Pass()→std::move() for iOS build.

BUG=557422
R=rickyz@chromium.org
TBR=jam@chromium.org

Committed: https://crrev.com/5e05b437032ffeb7bf9da7dcf1355fc668a33a9d
Cr-Commit-Position: refs/heads/master@{#369328}

[dcheng, 2016-01-13 23:04:58]

More of the usual. It turns out OS_MACOSX is also true for iOS builds, so I'm
going to try fixing iOS first.

+avi for general review / sanity check
+jam for global approval

[dcheng, 2016-01-13 23:05:02]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 23:10:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586833002/1

[rickyz (no longer on Chrome), 2016-01-14 00:35:23]

rickyz@chromium.org changed reviewers:
+ rickyz@chromium.org

[rickyz (no longer on Chrome), 2016-01-14 00:35:23]

I'm not so familiar with objective C, but the C++ changes lgtm

[dcheng, 2016-01-14 00:37:51]

https://codereview.chromium.org/1586833002/diff/1/base/memory/scoped_ptr_unit...
File base/memory/scoped_ptr_unittest.cc (right):

https://codereview.chromium.org/1586833002/diff/1/base/memory/scoped_ptr_unit...
base/memory/scoped_ptr_unittest.cc:416: scoped_ptr<ConDecLogger>&& rvalue =
std::move(scoper);
Oops, this got included by accident. I've reverted just this one file.

[dcheng, 2016-01-14 00:41:29]

Description was changed from

==========
Convert Pass()→std::move() for iOS build.

BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org
==========

to

==========
Convert Pass()→std::move() for iOS build.

BUG=557422
R=rickyz@chromium.org
TBR=jam@chromium.org
==========

[dcheng, 2016-01-14 00:41:30]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-01-14 00:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org
Link to the patchset: https://codereview.chromium.org/1586833002/#ps20001
(title: "Revert accidental //base change")

[commit-bot: I haz the power, 2016-01-14 00:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586833002/20001

[commit-bot: I haz the power, 2016-01-14 02:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:49:13]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)

[dcheng, 2016-01-14 02:49:38]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:54:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586833002/20001

[Avi (use Gerrit), 2016-01-14 03:14:55]

On 2016/01/13 23:04:58, dcheng wrote:
> More of the usual. It turns out OS_MACOSX is also true for iOS builds

Someone made that decision a while ago, so, um, yeah.

LGTM. Re ObjC, anything that touches scoped_ptr is by definition ObjC++, and the
C++ part of that follows the same rules as all of our other C++.

[commit-bot: I haz the power, 2016-01-14 04:41:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 04:43:41]

Description was changed from

==========
Convert Pass()→std::move() for iOS build.

BUG=557422
R=rickyz@chromium.org
TBR=jam@chromium.org
==========

to

==========
Convert Pass()→std::move() for iOS build.

BUG=557422
R=rickyz@chromium.org
TBR=jam@chromium.org

Committed: https://crrev.com/5e05b437032ffeb7bf9da7dcf1355fc668a33a9d
Cr-Commit-Position: refs/heads/master@{#369328}
==========

[commit-bot: I haz the power, 2016-01-14 04:43:43]

Patchset 2 (id:??) landed as
https://crrev.com/5e05b437032ffeb7bf9da7dcf1355fc668a33a9d
Cr-Commit-Position: refs/heads/master@{#369328}

[sdefresne, 2016-01-14 08:22:11]

On 2016/01/14 at 04:43:43, commit-bot wrote:
> Patchset 2 (id:??) landed as
https://crrev.com/5e05b437032ffeb7bf9da7dcf1355fc668a33a9d
> Cr-Commit-Position: refs/heads/master@{#369328}

Quick question: we have still lots of usage of .Pass() in downstream iOS code.
Should we invest effort in converting them to std::move() now (i.e. how imminent
is the removal of .Pass() from scoped_ptr<>)?

[dcheng, 2016-01-14 08:24:33]

On 2016/01/14 at 08:22:11, sdefresne wrote:
> On 2016/01/14 at 04:43:43, commit-bot wrote:
> > Patchset 2 (id:??) landed as
https://crrev.com/5e05b437032ffeb7bf9da7dcf1355fc668a33a9d
> > Cr-Commit-Position: refs/heads/master@{#369328}
> 
> Quick question: we have still lots of usage of .Pass() in downstream iOS code.
Should we invest effort in converting them to std::move() now (i.e. how imminent
is the removal of .Pass() from scoped_ptr<>)?

I have good news for you =)
I already have the tooling setup for the internal repo. I'm just waiting for
this patch to get merged into the internal repo, and then I'll run tooling
across the internal repo to (hopefully) catch most of the remaining instances.