chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java - Issue 1586783003: If you reload an offline page while online, load the online version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

Issue 1586783003: If you reload an offline page while online, load the online version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR fixes per fGorski Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

index 5ac6d81544333d5d0ac004c3bed6c756c1c395a3..4095422ef2152bc20a18e25e3774533087ec4408 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

@@ -71,6 +71,11 @@ public class OfflinePageTabObserver extends EmptyTabObserver {

}

@Override

+ public void onPageLoadStarted(Tab tab, String newUrl) {

+ OfflinePageUtils.preferOnlineVersion(mActivity, tab, newUrl);

+ }

+ @Override

public void onDestroyed(Tab destroyedTab) {

// Unregister this tab for OS connectivity notifications.

if (mListener != null) {

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | no next file with comments »